Page MenuHomeFreeBSD

Sanitize WRKSRC by replacing mulitple occurences of '//' by '/'.
ClosedPublic

Authored by tcberner on Jun 2 2017, 11:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 8:18 AM
Unknown Object (File)
Fri, Oct 10, 1:00 AM
Unknown Object (File)
Sep 9 2025, 2:04 PM
Unknown Object (File)
Sep 7 2025, 7:52 AM
Unknown Object (File)
Sep 4 2025, 11:29 PM
Unknown Object (File)
Sep 3 2025, 7:13 PM
Unknown Object (File)
Sep 3 2025, 12:43 PM
Unknown Object (File)
Sep 3 2025, 12:39 PM
Subscribers

Details

Summary

If WRKDIRPREFIX contains a trailing slash there are issues, as seen in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199297

I assume this fix is a little bit too simple...

devel/qt5-qmake  %  make -VWRKSRC WRKDIRPREFIX=/tmp
/tmp/usr/ports/devel/qt5-qmake/work/qtbase-opensource-src-5.7.1
devel/qt5-qmake  %  make -VWRKSRC WRKDIRPREFIX=/tmp/
/tmp/usr/ports/devel/qt5-qmake/work/qtbase-opensource-src-5.7.1
devel/qt5-qmake  %  make -VWRKSRC WRKDIRPREFIX=/tmp//
/tmp/usr/ports/devel/qt5-qmake/work/qtbase-opensource-src-5.7.1

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I would rather the WRKDIRPREFIX documentation at the top of the file be changed to say MUST NOT INCLUDE A TRAINLING SLASH

Does the reinplacement of // -> / impose too much of a computational hazard for it to be practical?

Add comment in the documentation, rather than sedding it.

I like that one better :-)

This revision is now accepted and ready to land.Jun 12 2017, 11:54 AM
This revision was automatically updated to reflect the committed changes.