Page MenuHomeFreeBSD
Differential D11032

Sanitize WRKSRC by replacing mulitple occurences of '//' by '/'.
ClosedPublic
Actions

Authored by tcberner on Jun 2 2017, 11:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 21, 10:15 PM
Unknown Object (File)
Sun, Sep 20, 6:49 PM
Unknown Object (File)
Sat, Sep 19, 10:55 PM
Unknown Object (File)
Aug 21 2026, 12:37 AM
Unknown Object (File)
Aug 8 2026, 7:55 PM
Unknown Object (File)
Aug 8 2026, 4:42 PM
Unknown Object (File)
Aug 6 2026, 8:09 PM
Unknown Object (File)
Aug 5 2026, 5:52 PM
View All Files
Subscribers
mat

Details

Reviewers
mat
Group Reviewers
portmgr
O5: Ports Framework
Commits
rP443599: Add note, that WRKDIRPREFIX must not end in '/'.
Summary

If WRKDIRPREFIX contains a trailing slash there are issues, as seen in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199297

I assume this fix is a little bit too simple...

devel/qt5-qmake  %  make -VWRKSRC WRKDIRPREFIX=/tmp
/tmp/usr/ports/devel/qt5-qmake/work/qtbase-opensource-src-5.7.1
devel/qt5-qmake  %  make -VWRKSRC WRKDIRPREFIX=/tmp/
/tmp/usr/ports/devel/qt5-qmake/work/qtbase-opensource-src-5.7.1
devel/qt5-qmake  %  make -VWRKSRC WRKDIRPREFIX=/tmp//
/tmp/usr/ports/devel/qt5-qmake/work/qtbase-opensource-src-5.7.1

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner created this revision.Jun 2 2017, 11:27 PM
Owners added a reviewer: O5: Ports Framework.Jun 2 2017, 11:27 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptJun 2 2017, 11:27 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B9642: Diff 29164.Jun 2 2017, 11:27 PM
mat added a comment.Jun 9 2017, 12:38 PM

I would rather the WRKDIRPREFIX documentation at the top of the file be changed to say MUST NOT INCLUDE A TRAINLING SLASH

tcberner added a comment.Jun 10 2017, 6:08 PM

Does the reinplacement of // -> / impose too much of a computational hazard for it to be practical?

tcberner updated this revision to Diff 29435.Jun 10 2017, 6:10 PM

Add comment in the documentation, rather than sedding it.

Harbormaster completed remote builds in B9784: Diff 29435.Jun 10 2017, 6:10 PM
mat accepted this revision.Jun 12 2017, 11:54 AM

I like that one better :-)

This revision is now accepted and ready to land.Jun 12 2017, 11:54 AM
Closed by commit rP443599: Add note, that WRKDIRPREFIX must not end in '/'. (authored by tcberner). · Explain WhyJun 14 2017, 8:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
2 linesO5: Ports Framework

Diff 29615

View Options

head/Mk/bsd.port.mk

Loading...