Page MenuHomeFreeBSD

Fix typo in Driver Type A/C/D capability checks in sdhci.
ClosedPublic

Authored by ivadasz on May 30 2017, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 8:23 AM
Unknown Object (File)
Dec 24 2023, 7:14 PM
Unknown Object (File)
Dec 9 2023, 5:52 PM
Unknown Object (File)
Nov 22 2023, 2:35 PM
Unknown Object (File)
Nov 22 2023, 11:37 AM
Unknown Object (File)
Nov 22 2023, 10:53 AM
Unknown Object (File)
Nov 22 2023, 10:37 AM
Unknown Object (File)
Nov 13 2023, 2:00 PM
Subscribers
None

Details

Summary

Use the SDHCI_CAN_DRIVE_TYPE_A/_C/_D masks to check for Driver Type support,
instead of using the SDHCI_CTRL2_DRIVER_TYPE_A/_C/_D values which are meant
for setting the Driver Type in the HOST_CONTROL2 register.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The Driver Type capability bits are located in the CAPABILITIES2 register.

This revision is now accepted and ready to land.May 30 2017, 11:05 PM
marius requested changes to this revision.May 31 2017, 7:20 PM

I no longer seem to be able to add inline comments in this crappy review thing; while at it,
the second hunk involved in printing capabilities should be changed to operate based on
host_caps and MMC_CAP_DRIVER_TYPE_x as generally, only SDHCI_CAN_VDD_x don't
have corresponding bits in host_caps.

This revision now requires changes to proceed.May 31 2017, 7:20 PM
This revision was automatically updated to reflect the committed changes.