There is no reason to run 'true' for empty targets
Details
Details
- Reviewers
mat - Group Reviewers
portmgr - Commits
- rP438106: Stop creating stubs targets calling /usr/bin/true
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| Mk/bsd.port.mk | ||
|---|---|---|
| 2783–2792 ↗ | (On Diff #27243) | Maybe change that and put the ignorelist-verbose: taget before the first .if test, and remove the .else. |
| 2874–2876 ↗ | (On Diff #27243) | Maybe put the .if defined(NO_CHECKSUM) around the call to checksum.sh and remove this. |
| 2884–2887 ↗ | (On Diff #27243) | Maybe move this to the test: definition at the end. |
| 2897–2900 ↗ | (On Diff #27243) | Mmm, NO_DESCRIBE is not currently in use, and I don't feel like it is a good idea anyway, many remove it. |
| 2912 ↗ | (On Diff #27243) | Maybe just remove this, if it is created, it goes in the targets pipeline, if not, it does not. |
| 2920–2924 ↗ | (On Diff #27243) | GNOME_OPTION_MSG was removed ages ago, maybe just remove all this. |
| 3319–3320 ↗ | (On Diff #27243) | Why not just remove the .elif ? If it does not exist, it just won't be added to the targets pipeline. |
| 3432–3434 ↗ | (On Diff #27243) | Nothing currently uses install-mtree, time to go ? |
| 3703–3705 ↗ | (On Diff #27243) | maybe change that to create a dependency below so that the target is not created if it is not needed, like .if target(pre-distclean) distclean: pre-distclean .endif |
| Mk/bsd.port.mk | ||
|---|---|---|
| 2912 ↗ | (On Diff #27243) | This one must exist to be hooked on |
| 3432–3434 ↗ | (On Diff #27243) | Can't :) added a comment :) |
| 3703–3705 ↗ | (On Diff #27243) | I think we should just nuke pre-distclean |
| Mk/bsd.port.mk | ||
|---|---|---|
| 3703–3705 ↗ | (On Diff #27243) | It was my first reaction, yes, I'll have a look at if it was ever used. |
| Mk/bsd.port.mk | ||
|---|---|---|
| 3703–3705 ↗ | (On Diff #27243) | I think we should just keep this removal for another patchset :) |
| Mk/bsd.port.mk | ||
|---|---|---|
| 2912 ↗ | (On Diff #27243) | Mmmm, it does not need to be hooked in, it's in _SANITY_SEQ, so, I don't understand. |
| 3703–3705 ↗ | (On Diff #27243) | So, I asked git log -Spre-distclean -p, it was added in 1996 and never, ever used, so, yeah, remove it :-) |
Comment Actions
Looks good to me, it might need an exp-run, I'll leave the other portmgr members look at it here.