Page MenuHomeFreeBSD

psm(4), evdev support part 2: psm softc locking
AbandonedPublic

Authored by wulf_cicgroup.ru on Apr 3 2017, 10:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 11:25 PM
Unknown Object (File)
Dec 23 2023, 4:35 AM
Unknown Object (File)
Dec 12 2023, 7:57 PM
Unknown Object (File)
Oct 28 2023, 4:42 AM
Unknown Object (File)
Sep 9 2023, 2:44 PM
Unknown Object (File)
Jul 7 2023, 7:42 AM
Unknown Object (File)
Jun 29 2023, 4:02 PM
Unknown Object (File)
Jun 29 2023, 3:44 AM
Subscribers

Details

Reviewers
gonzo
Summary

psm(4): Serialize softc access with mutex.
Mark interrupt and cdev handlers MPSAFE

Part of https://reviews.freebsd.org/D10207

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

It looks OK to me but could you email link to this review to freebsd-arch@ and ask for second opinion? With code this old there might be some hidden pitfalls. If nobody raises any concerns - go ahead and commit it.

could you email link to this review to freebsd-arch@

I will do that

Change is obsolete.
After some discussion with bde@ (on arch@ and private) it is turned out that nothing but Giant can be used to serialize access to I8042 ports currently.
Although it is possible to move psm softc from Giant to private mutex that would complicate things as all calls to I8042 should be done with Giant taken so psm mutex should be released at this time.

Vladimir, could you abandon this change if it's obsolete and you don't have any plans to update the patch?

Thanks

Finally I found out how to abandon revision after some googling. It is not very intuitive.