psm(4): Serialize softc access with mutex.
Mark interrupt and cdev handlers MPSAFE
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
It looks OK to me but could you email link to this review to freebsd-arch@ and ask for second opinion? With code this old there might be some hidden pitfalls. If nobody raises any concerns - go ahead and commit it.
Change is obsolete.
After some discussion with bde@ (on arch@ and private) it is turned out that nothing but Giant can be used to serialize access to I8042 ports currently.
Although it is possible to move psm softc from Giant to private mutex that would complicate things as all calls to I8042 should be done with Giant taken so psm mutex should be released at this time.
Vladimir, could you abandon this change if it's obsolete and you don't have any plans to update the patch?
Thanks
Finally I found out how to abandon revision after some googling. It is not very intuitive.