Details
Details
- Reviewers
emaste - Group Reviewers
Linux Emulation
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Possible bikeshedding comment, the nested () seem a bit odd to me - e.g. linux(517 (100123)): foo. Consider if you like something like pid/tid: linux(517/100123): foo.
In the commit message I would mention that tid is an addition - i.e. print out thread id in the debug messages -> print the thread id in addition to the pid in debug messages
sys/amd64/linux32/linux.h | ||
---|---|---|
43–44 | Sorry for possibly bikeshedding here, but the nested () seem a bit odd - e.g. linux(517 (100123)): foo What about something like pid/tid: linux(517/100123): foo |
Comment Actions
Btw, if you end your commit message with
Differential Revision: https://reviews.freebsd.org/D1026
it will close automatically when you commit.