Update devd patch for x11-servers/xorg-server

[ak]

Summary

Update to devd patch. Add warning in case if device file is already opened, add ability to survive devd restart. The patch is against xorg-dev repo.

Test Plan

Apply the patch. Build and start xorg, check log for 'already opened' warning for at least one (attached to console) keyboard, restart devd, plug/unplug keyboard(s)/mouse(s).

[dumbbell]

x11-servers/xorg-server/files/extra-new-devd

248 ↗

(On Diff #2151)

Typo: s/devoce/device/ and s/it attached/is attached/

I would rephrase like this:

Don't pass "device" option if the device is a keyboard and is already attached to the console (ie. open() fails). This would activate a special logic in xf86-input-keyboard.

[kwm]

Updated here:
https://github.com/freebsd/freebsd-ports-graphics/commit/84b398944e5a40e0f9e82f9274cd263b8912b46e

I would propose keeping this open while we tested it.

[bapt]

x11-servers/xorg-server/files/extra-new-devd

76 ↗

(On Diff #2151)

Why removing uhid?

[ak]

76 Why removing uhid?

Good catch! This is my local change sneaked in. My keyboard has multimedia keys which attach to uhid and xorg busies the device file. On the other hand, I've never seen mouse with uhid device. Perhaps there is no harm to keep this change.

[ak]

Improve the comment for keyboard's check.

[ak]

Sync with github.com/freebsd/freebsd-ports-graphics repo:

• Fix mix of tab and spaces, make indentation consistent
• Cleanup of extra-devd patch
  • Use true/false instead od 0/1 as return value from the bool function
  • Combine two similar checks
  • Rearrange logic to remove goto and gratuitous continue
  • Add todo comment about usb_id
  • Misc: s/LogMessageVerb/LogMessage/, wrap comment, lowercase two error messages