Differential D1000

Backend changes to add interrupt support to GPIO pins on bcm2835_gpio (RPi)
ClosedPublic
Actions

Authored by loos on Oct 23 2014, 5:51 PM.

Details

Reviewers

adrian

Group Reviewers

ARM

Commits

rS278215: Add GPIO interrupt support for BCM2835 (Raspberry pi).

Summary

These are the changes to the backend GPIO driver on RPi, it allow the use of
GPIO interrupts for kernel devices (together with the changes on D999).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

loos updated this revision to Diff 2095.Oct 23 2014, 5:51 PM

loos retitled this revision from to Backend changes to add interrupt support to GPIO pins on bcm2835_gpio (RPi).

loos updated this object.

loos edited the test plan for this revision. (Show Details)

loos added reviewers: ARM, adrian.

There are a bunch of empty lines that you might want to remove.

sys/arm/broadcom/bcm2835/bcm2835_gpio.c
3 ↗	(On Diff #2095)	You should update the copyright year.
1053 ↗	(On Diff #2095)	Why do we need this check? If this is false, we end up using the previous 'reg' value below.

loos added inline comments.Oct 28 2014, 12:44 PM

sys/arm/broadcom/bcm2835/bcm2835_gpio.c
3 ↗	(On Diff #2095)	right!
1053 ↗	(On Diff #2095)	That's the idea, reuse the previous value of 'reg'. Each 'reg' reading return the interrupt status of a full bank (32 bits - 32 pins), so reading it only once per bank should suffice.

Closed by commit rS278215 (authored by @loos).

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

broadcom/

bcm2835/

bcm2835_gpio.c

314 lines

Diff 3635

View Options

head/sys/arm/broadcom/bcm2835/bcm2835_gpio.c

Backend changes to add interrupt support to GPIO pins on bcm2835_gpio (RPi)ClosedPublicActions