User Details
- User Since
- May 30 2017, 11:42 AM (362 w, 3 d)
Mon, Apr 22
Mar 19 2024
Mar 1 2024
It is worth noting that building with clang 18 currently fails (https://api.cirrus-ci.com/v1/task/5600331233492992/logs/build_world.log), I imagine this will be ironed out as we go along.
Feb 29 2024
Feb 12 2024
Feb 11 2024
This looks good. It makes an extra effort to find sed.
I just wonder if it is possible to define SED=${SED:-$(Exists -x /usr/bin/sed /rescue/sed)} only once in rc.subr, maybe at the beginning?
ShellCheck usually recommends avoiding backticks (https://www.shellcheck.net/wiki/SC2006).
Feb 6 2024
Updated in 11da791920ba285f0832f09cb504ac81e35ff8d1.
Jan 20 2024
Nice!
I have slightly tested it, and it is backwards compatible... even with the old (unrelated) bug 268397 (this is probably a race somewhere else), that reproduces easily by stopping/starting the jail service 10 times (repo/branch here: https://github.com/jlduran/jng-jib-jails-test/tree/jng2)
Minor typo.
Jan 4 2024
Dec 30 2023
I was not able to run the _.disk.iso image (maybe it gets truncated?), nowadays, a memstick makes more sense anyway.
Dec 28 2023
This one landed as e9da71cd35d46ca13da4396d99e0af1703290e68 ?
Dec 13 2023
Hi! It appears that bug #275743 is reporting something similar for 12.4.
Dec 11 2023
This is simple, yet useful enough... being more specific may confuse users (just like me). I for one, do a pkg upgrade -y, however, pkg will recommend you a pkg bootstrap -f, but I never know if pkg-static is actually preferred.
Dec 9 2023
Dec 7 2023
Note to self:
It will likely land as two separate commits:
- Vendor import of vendor/NetBSD/mtree.
- Vendor import of vendor/NetBSD/tests.
b1c95af45488bef649e9a84890e2414ff80b3a00 landed, somehow I preferred this one from the IERS.
Dec 6 2023
Dec 5 2023
Or if someone from ports can MFC pkg into quarterly, even better. But this is good for now. Thank you!
Yes!
Sorry, I got the revision numbers initially wrong. This is my take on D42903.
https://cirrus-ci.com/task/5157804504252416?logs=setup#L15 states that pkg version is 1.20.8, so @override_prefix is not yet available (starting on 1.20.9):
Dec 2 2023
Dec 1 2023
quite a few other platforms don't have them.
I had missed this important bit. Thank you!
Hum... Maybe I'm missing something:
➜ uname -a Darwin macbook-pro.home.arpa 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:12 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T8103 arm64 ➜ cat /usr/share/locale/el_GR.UTF-8/LC_TIME Ιαν Φεβ Μαρ Απρ Μαϊ Ιον Ιολ Αυγ Σεπ Οκτ Νοε Δεκ Ιανουαρίου Φεβρουαρίου Μαρτίου Απριλίου Μαΐου Ιουνίου Ιουλίου Αυγούστου Σεπτεμβρίου Οκτωβρίου Νοεμβρίου Δεκεμβρίου Κυρ Δευ Τρι Τετ Πεμ Παρ Σαβ Κυριακή Δευτέρα Τρίτη Τετάρτη Πέμπτη Παρασκευή Σάββατο %H:%M:%S %d/%m/%Y %a %e %b %X %Y πμ μμ %a %e %b %Y %X %Z Ιανουάριος Φεβρουάριος Μάρτιος Απρίλιος Μάϊος Ιούνιος Ιούλιος Αύγουστος Σεπτέμβριος Οκτώβριος Νοέμβριος Δεκέμβριος dm %I:%M:%S %p
Thank you for this nice addition! It does, however, fail when cross-building on macOS:
https://pipelinesghubeus2.actions.githubusercontent.com/8Zobszzx1fzKxF8BHSJLzmYvAIfV7kuYLyhz5o35SqgHcKvvbE/_apis/pipelines/1/runs/19723/signedlogcontent/7?urlExpires=2023-12-01T17%3A06%3A05.6816198Z&urlSigningMethod=HMACV1&urlSignature=SNFGWVRwQUneUXeKKdbEWuKQ64ngWnBLEXpcY8%2FCEI0%3D
The reason being, Darwin does not have those constants (defined in a250649bd8d6999d8511cb826085deb34236f3f3 ):
https://github.com/apple-oss-distributions/Libc/blob/main/include/langinfo.h
On Linux, this is not a problem (https://www.gnu.org/software/libc/manual/html_node/The-Elegant-and-Fast-Way.html).
I trust you would know how best to proceed, whether manually adding the constants to the cross-build tools or #ifdef-ing APPLE or else.
Thank you again!
Nov 28 2023
Is that really testing for the same case?
# setup_vnet(pytest:TestRtNlRoute:test_add_route4_ll_gw) run: '/sbin/sysctl net.inet6.ip6.dad_count=0' run: '/sbin/ifconfig epair0a up' run: '/usr/sbin/ndp -i epair0a -disabled' run: '/sbin/ifconfig epair0a inet6 2001:db8::1/64' run: '/sbin/ifconfig epair0a inet6' run: '/sbin/ifconfig tun create'The whole point of D41330 was to handle the case where the interface doesn't have a v4/v6 address.
- Add test for IPv6
- Update commit message (plural)
Line 29?
Nov 26 2023
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275341
Fixes:
# ifconfig wg1 create # ifconfig wg1 up # route -n add 10.2.0.0/24 -interface wg1
Nov 9 2023
Sorry to bother again, would it be possible to MFC just this commit (4d348e83b738347f6aaf2b110459a01c5402d04e) to stable/13, the other commits in this series cannot be applied.
Reported by: Jenkins
https://ci.freebsd.org/view/Test/job/FreeBSD-stable-13-riscv64-test/936/testReport/sbin.ping/
Nov 8 2023
make -C lib/libifconfig && make -C lib/libnv && make -C tools/bsdbox works. Thanks!
Nov 6 2023
I would like to kindly request an MFC to stable/14 of at least this fix.
Reported by: Jenkins
https://ci.freebsd.org/view/Test/job/FreeBSD-stable-14-riscv64-test/lastCompletedBuild/testReport/sbin.ping/ping_test/ping6_c1_s8_t1/
(pasting RISC-V, as aarch64 images are failing)
Nov 2 2023
Oct 26 2023
Oct 21 2023
I think that we should import https://github.com/NetBSD/src/commit/38862c874c4a2bcca9dce5c0966ea19ddabd523e first.
I wonder if we should skip only the failing one?
Oct 18 2023
Thank you! I think the project insists that the documentation be in American English:
Oct 17 2023
Oct 16 2023
Test disabled in 2682a15527241278c9aa46c4907d3b07460b8ec0.
Oct 14 2023
As long as we are keeping the old ping6 as an alias, I believe this is OK. Try pinging @asomers .
Oct 12 2023
Oct 11 2023
Oct 10 2023
Oct 9 2023
Oct 7 2023
Updated commit message.
Oct 6 2023
As you well pointed out, here is the fix from NetBSD:
I'll investigate a bit further. I am able to reproduce it on my mac:
Sep 28 2023
Will this affect upgrading poudriere jails with a kernel, see poudriere-jail(8)'s -K?
Sep 27 2023
I noticed this change broke macOS cross-builds on GitHub. I guess due to the fact that man clang on macOS says: The default C++ language standard is gnu++98.
Sep 11 2023
Sep 6 2023
Nice! Thank you!
Also PMTUD problems, UNIX traceroute "not working", the list of issues can be long.
I'll go ahead and disturb @freebsd-transport, to ask if they have something to say against this change.
Aug 17 2023
- Remove extra white lines after the $FreeBSD$ tag removal
Aug 16 2023
- Rebase (remove FreeBSD RCSIDs).
Aug 12 2023
Aug 11 2023
As you might already know, commit 28f6c2f292806bf31230a959bc4b19d7081669a7 broke GCC 12 compilation (https://cirrus-ci.com/task/6695038801936384).
I did the lazy thing and added:
CXXFLAGS.gcc+= -Wno-error
to gmock_main/Makefile and gtest_main/Makefile, but I believe a more granular approach is also desired for GCC.
Aug 9 2023
Aug 5 2023
Rebase.
Aug 3 2023
Aug 1 2023
Jul 31 2023
Jul 28 2023
Jul 19 2023
Thank you!
I also had to add:
LDFLAGS+= -Wl,-znoexecstack
to secure/lib/libcrypto/**/**/Makefile.
Is there a reason why this change was not MFCd? Thank you!