Paths

Table of Contentst

Differential D44871

adduser: A few more improvements.
ClosedPublic
Actions

Authored by des on Apr 19 2024, 4:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 21, 11:55 PM

	Unknown Object (File)
	Tue, May 21, 11:55 PM

	Unknown Object (File)
	Tue, May 21, 11:18 PM

	Unknown Object (File)
	Fri, May 3, 8:14 AM

	Unknown Object (File)
	Fri, May 3, 8:13 AM

	Unknown Object (File)
	Fri, May 3, 4:45 AM

	Unknown Object (File)
	Mon, Apr 29, 11:20 AM

	Unknown Object (File)
	Sun, Apr 28, 5:36 PM

View All 13 Files

Subscribers

jlduran_gmail.com

Details

Reviewers

Commits

rGedff88aee215: adduser: Really fix a syntax error
rG9e8618276fad: adduser: Really fix a syntax error
rG5cafc38f1129: adduser: Fix a syntax error
rGb37333899bd2: adduser: A few more improvements.

Summary

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Apr 19 2024, 4:04 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 19 2024, 4:04 PM

des requested review of this revision.Apr 19 2024, 4:04 PM

Harbormaster completed remote builds in B57222: Diff 137396.Apr 19 2024, 4:04 PM

Looks good to me.

In D44871#1023012, @jrm wrote:

Looks good to me.

Then accept it, please.

jrm accepted this revision.Apr 20 2024, 4:47 PM

This revision is now accepted and ready to land.Apr 20 2024, 4:47 PM

Closed by commit rGb37333899bd2: adduser: A few more improvements. (authored by des). · Explain WhyApr 20 2024, 7:36 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb37333899bd2: adduser: A few more improvements..

jlduran_gmail.com added a subscriber: jlduran_gmail.com.Apr 22 2024, 6:50 PM

jlduran_gmail.com added inline comments.

usr.sbin/adduser/adduser.sh
480	Sorry, for the late review, as this is already committed, but I do not understand this change. Wouldn't it throw an error?

jrm added inline comments.Apr 22 2024, 6:55 PM

usr.sbin/adduser/adduser.sh
480–481	It looks good to me. It's now saying if the zfs kernel module isn't loaded or the user opted not to have the zfs home dataset created.

jrm added inline comments.Apr 22 2024, 7:01 PM

usr.sbin/adduser/adduser.sh
480	Oh, I see what you're saying. The syntax is wrong. The `; then` is missing.

jlduran_gmail.com added inline comments.Apr 22 2024, 7:02 PM

usr.sbin/adduser/adduser.sh
480	Precisely! You beat me to it. Thank you!
480–481	I guess, what I meant was, isn't it missing a `; then` and indenting with 4 spaces instead of a tab the next line?

jrm added a commit: rG5cafc38f1129: adduser: Fix a syntax error.Apr 22 2024, 7:09 PM

des mentioned this in rG4f4905b2ef1c: adduser: Overhaul..Mon, Apr 29, 10:15 AM

des added a commit: rG9e8618276fad: adduser: Really fix a syntax error.Mon, Apr 29, 10:30 AM

des added a commit: rGedff88aee215: adduser: Really fix a syntax error.

des mentioned this in rGb7a56907af0c: adduser: Overhaul..Mon, Apr 29, 10:34 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

adduser/

24 lines

Diff 137445

usr.sbin/adduser/adduser.sh

Loading...