Looks great!

This fails in Poduriere and there's no need to open two reports, just stick with PR 279330
I've submitted an alternative patch (feel free to add back the libmd5 stuff), it came about 1 hour later because of the testing in Poudriere...

See note about for loop in post-install section

Please post using the correct channel and there's no need to assign it specific committers, https://bugs.freebsd.org/bugzilla/

Approved

LGTM

Commit https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279058 first then this one,

I guess this is good to go now?

Don't safeguard run option

Simplify logic as suggested by mat

Add "(implies make)" to description

I think we misunderstood each other, either variant is fine by me

Add missing check for MAKE_ARGS

@arrowd @mat
Any other changes you'd like to see or can I push it?

• Change !empty(ninja_ARGS:M*samurai*) to !empty(ninja_ARGS:Msamurai) as suggested by tobik
• Fix whitespace as noted by mat

Thanks for the feedback, I think this one is a bit better

• Use internal variable instead of evaluating supplied ARGS
• Simplify if statements

Attach patch generated with -U99999 for better context