Page MenuHomeFreeBSD

Scripts/qa.sh: fine tune USES=ssl recommendation
ClosedPublic

Authored by fernape on Sep 25 2023, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 2:59 AM
Unknown Object (File)
Fri, Apr 26, 2:59 AM
Unknown Object (File)
Fri, Apr 26, 2:59 AM
Unknown Object (File)
Fri, Apr 26, 2:57 AM
Unknown Object (File)
Fri, Apr 26, 2:57 AM
Unknown Object (File)
Fri, Apr 26, 1:50 AM
Unknown Object (File)
Thu, Apr 25, 8:55 PM
Unknown Object (File)
Mar 29 2024, 11:07 PM
Subscribers

Details

Summary

Try to avoid the "you need USES=ssl" in ports that provide a libssl.so or
libcrypto.so libraries themselves as security/openssl or security/libressl.

Comes from PR270035

Test Plan

Apply patch and make openssl, libressl or other ssl ports.
If building other ports that don't provide those libraries by themselves, then
the warning still applies

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mk/Scripts/qa.sh
140–146

As we don't need whatever list_stagedir_elfs outputs, maybe here tests its output directly, something like :

if list_stagedir_elfs ... | grep -q 'lib.*.so'; then
...
Mk/Scripts/qa.sh
118

This is not needed any more now.

140–146

I know I'm being pedantic but could you add an empty line between the EOF and the if ? (to ease reading)

Remove unused variable
Add empty line to improve readability

This revision is now accepted and ready to land.Jan 20 2024, 5:41 PM