Page MenuHomeFreeBSD
Differential D28703

Allow sysctl hw.machine/hw.machine_arch in capability mode
ClosedPublic
Actions

Authored by val_packett.cool on Feb 16 2021, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 23, 7:27 PM
Unknown Object (File)
Mon, May 6, 1:46 AM
Unknown Object (File)
Thu, May 2, 6:03 PM
Unknown Object (File)
Apr 21 2024, 8:07 PM
Unknown Object (File)
Mar 6 2024, 10:30 PM
Unknown Object (File)
Jan 2 2024, 1:49 AM
Unknown Object (File)
Dec 20 2023, 7:01 AM
Unknown Object (File)
Dec 13 2023, 5:18 AM
View All 26 Files
Subscribers
andrew
emaste
imp
jhibbits

Details

Reviewers
manu
emaste
Group Reviewers
Contributor Reviews (src)
capsicum
Commits
rG4a1c4de232af: Allow sysctl hw.machine/hw.machine_arch in capability mode
Summary

There's no harm in reading strings like 'amd64'.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Feb 16 2021, 2:41 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 16 2021, 2:41 PM
Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B37051: Diff 84012.Feb 16 2021, 2:41 PM
val_packett.cool requested review of this revision.Feb 16 2021, 2:41 PM
val_packett.cool added reviewers: emaste, Contributor Reviews (src).Feb 16 2021, 2:42 PM
val_packett.cool set the repository for this revision to rG FreeBSD src repository.
val_packett.cool added a reviewer: capsicum.Feb 16 2021, 3:12 PM
manu accepted this revision.Feb 16 2021, 5:08 PM

LGTM

This revision is now accepted and ready to land.Feb 16 2021, 5:08 PM
val_packett.cool updated this revision to Diff 116540.Feb 5 2023, 8:54 PM

rebased (bye bye MIPS \o/). ping!

This revision now requires review to proceed.Feb 5 2023, 8:54 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 5 2023, 8:54 PM
Harbormaster completed remote builds in B49538: Diff 116540.Feb 5 2023, 8:54 PM
emaste accepted this revision.Feb 6 2023, 3:10 PM
This revision is now accepted and ready to land.Feb 6 2023, 3:10 PM
emaste added a comment.Feb 6 2023, 3:10 PM

Do you have a public Git branch somewhere that I can fetch your changes from?

val_packett.cool added a comment.Feb 6 2023, 6:50 PM
In D28703#873145, @emaste wrote:

Do you have a public Git branch somewhere that I can fetch your changes from?

ok, now I do, at https://codeberg.org/valpackett/freebsd-src right now.

What *is* the deal with phab and git metadata after all D: Why can I *sometimes* arc patch with author data and all the things but it's still weird?

Closed by commit rG4a1c4de232af: Allow sysctl hw.machine/hw.machine_arch in capability mode (authored by val_packett.cool, committed by emaste). · Explain WhyFeb 6 2023, 7:01 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG4a1c4de232af: Allow sysctl hw.machine/hw.machine_arch in capability mode.
emaste added a comment.Feb 6 2023, 7:03 PM

What *is* the deal with phab and git metadata after all D: Why can I *sometimes* arc patch with author data and all the things but it's still weird?

I don't know - as far as I'm aware there's no usable way to transport git metadata in and out of phab.

emaste mentioned this in D43281: x86: Export cpu_model[].Jan 3 2024, 12:57 AM

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
2 lines
arm64/
arm64/
3 lines
kern/
2 lines
powerpc/
powerpc/
2 lines
riscv/
riscv/
2 lines
x86/
x86/
4 lines

Diff 116621

View Options

sys/arm/arm/identcpu-v6.c

Loading...
View Options

sys/arm64/arm64/identcpu.c

Loading...
View Options

sys/kern/kern_mib.c

Loading...
View Options

sys/powerpc/powerpc/machdep.c

Loading...
View Options

sys/riscv/riscv/identcpu.c

Loading...
View Options

sys/x86/x86/identcpu.c

Loading...