Paths

Table of Contentst

Differential D45227

kernel: Make some compiling time constant const
Needs ReviewPublic
Actions

Authored by zlei on Fri, May 17, 10:00 AM.

Tags

None

Referenced Files

	F86041416: D45227.diff
	Fri, Jun 14, 12:25 PM

	Unknown Object (File)
	Thu, Jun 13, 6:30 PM

	Unknown Object (File)
	Wed, Jun 5, 10:02 AM

	Unknown Object (File)
	Tue, May 21, 4:44 AM

	Unknown Object (File)
	Sun, May 19, 8:40 PM

	Unknown Object (File)
	Sun, May 19, 2:11 AM

	Unknown Object (File)
	Sun, May 19, 2:11 AM

Subscribers

Details

Reviewers

imp
emaste
mjg
des
andrew
manu

Summary

While reviewing D44760 I realized that the kernel version and some other
variables are generated by sys/conf/newvers.sh at compiling time. Given they
are not subjected to change, make them constant.

No functional change intended.

MFC after: ???

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Fri, May 17, 10:00 AM

Herald added a reviewer: andrew. · View Herald TranscriptFri, May 17, 10:00 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, olce, jhibbits, delphij. · View Herald Transcript

zlei requested review of this revision.Fri, May 17, 10:00 AM

zlei added inline comments.Fri, May 17, 10:05 AM

sys/conf/newvers.sh
321	Strictly these are KBI changes. But if we have never promised that those compile time constants can be altered by 3rd party modules, then this change is safe to MFC.

@khng I think with this change even shadowing those global variables can be easily caught.

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

4 lines

arm64/

arm64/

2 lines

compat/

linux/

2 lines

conf/

14 lines

contrib/

openzfs/

include/

os/

freebsd/

spl/

sys/

10 lines

module/

os/

freebsd/

spl/

6 lines

kern/

22 lines

9 lines

3 lines

powerpc/

powerpc/

5 lines

riscv/

riscv/

6 lines

sys/

4 lines

8 lines

8 lines

x86/

x86/

4 lines

Diff 138640

sys/arm/arm/identcpu-v6.c

Loading...

sys/arm64/arm64/identcpu.c

Loading...

sys/compat/linux/linux_sysctl.c

Loading...

sys/conf/newvers.sh

Loading...

sys/contrib/openzfs/include/os/freebsd/spl/sys/misc.h

Loading...

sys/contrib/openzfs/module/os/freebsd/spl/spl_misc.c

Loading...

sys/kern/init_main.c

Loading...

sys/kern/kern_mib.c

Loading...

sys/kern/kern_xxx.c

Loading...

sys/powerpc/powerpc/machdep.c

Loading...

sys/riscv/riscv/identcpu.c

Loading...

sys/sys/copyright.h

Loading...

sys/sys/sysctl.h

Loading...

sys/sys/systm.h

Loading...

sys/x86/x86/identcpu.c

Loading...