Drop an unneeded assignment to ->pool in _unfree().

Avoid an unneeded write to pool in phys_free_pages.

In vm_phys_free_pages, I'd be happy to make a change that might not be strictly in the spirit of this change.

Add a KASSERT.

Break a too-long line.

In response to offline feedback, reduce needless changes to the pool field, where it is changed from A to B and then back to A.

Looks good to me.

Address whitespace issues.

Make changes to address feedback.

Rename (function) ilog2 so that it differs from (macro) ilog2. Rename the other functions too, and make the parameter name the same across all ilog2 functions/macros.

Drop the ilog2 definition from log2.h.

Remove unneeded KASSERT.

@whu: This change would drop the definition of ilog2 that you included in sys/dev/mana/gdma_util.h. However, that function, called ilog2(x), actually returns x + log2(x), because it initializes 'log' to x, and not to 0.

powerpc64 is a trickier beast. You need to 'make TARGET=powerpc TARGET_ARCH=powerpc64 ...' (explicitly specify TARGET_ARCH)

In D45170#1030344, @jhibbits wrote:

PPC LGTM. If you haven't, test a buildkernel with MPC85XX (powerpc) and QORIQ64 (powerpc64) just to be safe.

Change ilog2 to ilog2l where appropriate. Drop bslr, since it's just another name for ilog2l.

Others have used the ilog2 name for the same function. Drop those other definitions.

Update to leave out vm_radix.c.

Calculate the loop bound a little more efficiently. Reorder some computations within the loop to use fewer registers.

Move macro definitions, as suggested.

Restore pmap_load calls dropped from pmap_unwire_ptp.

Combine two short lines into one.

Refresh, seeking review.

Fix typos identified by @markj.

Edit a couple of comments.

Add assertion. Add/update some comments.

Fix a comment, suggested by @alc.

For @alc, change a semicolon to empty braces.

As @alc suggests, remove a redundant assertion (aren't they all redundant?), and a pointless NULL check, and a comment which in no way improved performance.

Apply @alc suggestions. Remove some inessential parts.

Fix an assertion identified by @markj.

Address feedback from @alc.

Re-enter an iterator for checking empty blocks.

Add a missing assignment.

Apply suggestions from @markj.

Don't modify m_ret in the loop, in case iteration happens and that breaks FOREACH. Save the potential return value in m_val instead.