Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

kp committed rGde4bfd6b9987: udp_var: correct intoudpcb macro unintended identifier dependency (authored by linnemannr_gmail.com).
udp_var: correct intoudpcb macro unintended identifier dependency
Fri, Jun 14, 3:30 PM

Thu, Jun 13

kp added a comment to D45585: ifconfig: turn interface address without mask into an error.

Open question: when do we commit this? Now, in advance of 15.0? As soon as stable/15 branches, so that it will first arrive in 16.0?

Thu, Jun 13, 7:16 PM
kp committed rG49e0e1481778: pf: add sctp multihome probe points (authored by kp).
pf: add sctp multihome probe points
Thu, Jun 13, 12:46 PM
kp committed rG00a51ada6bed: pf: add sctp multihome probe points (authored by kp).
pf: add sctp multihome probe points
Thu, Jun 13, 12:46 PM

Wed, Jun 12

kp committed rG1296443295ab: u3g: Add support for SIM7600G (authored by Maxime Thiebaut <maxime+freebsd@thiebaut.dev>).
u3g: Add support for SIM7600G
Wed, Jun 12, 9:35 PM
kp committed rG83549ee250c0: u3g: Add support for SIM7600G (authored by Maxime Thiebaut <maxime+freebsd@thiebaut.dev>).
u3g: Add support for SIM7600G
Wed, Jun 12, 9:35 PM
kp committed rG07ed2396985f: pf: make TCP sequence number tracking less strict by one octet for FIN packets (authored by kp).
pf: make TCP sequence number tracking less strict by one octet for FIN packets
Wed, Jun 12, 9:35 PM
kp committed rG20a2fe68faac: pf: correctly reset max_win if the SYN-ACK lacks a wscale option. (authored by kp).
pf: correctly reset max_win if the SYN-ACK lacks a wscale option.
Wed, Jun 12, 9:35 PM
kp accepted D45570: ifconfig: Fix default netmask calculation.
Wed, Jun 12, 5:57 PM

Tue, Jun 11

kp committed rG8fb5dc88ad8e: pf: fix overly large copy in pf_rule_to_krule() (authored by kp).
pf: fix overly large copy in pf_rule_to_krule()
Tue, Jun 11, 1:28 PM
kp committed rG357d111ef71f: pf tests: make ether:dummynet test a little more robust (authored by kp).
pf tests: make ether:dummynet test a little more robust
Tue, Jun 11, 1:28 PM
kp committed rGc3fe41b3a375: vnet tests: check for if_bridge.ko (authored by kp).
vnet tests: check for if_bridge.ko
Tue, Jun 11, 1:28 PM
kp committed rGd92f239a92c4: pf: fix overly large copy in pf_rule_to_krule() (authored by kp).
pf: fix overly large copy in pf_rule_to_krule()
Tue, Jun 11, 1:28 PM
kp committed rG154dd1eaa643: vnet tests: check for if_bridge.ko (authored by kp).
vnet tests: check for if_bridge.ko
Tue, Jun 11, 1:28 PM

Mon, Jun 10

kp closed D43712: vmxnet3: make descriptor count checks more robust.
Mon, Jun 10, 9:06 AM
kp committed rG3ff0dc1af85e: vmxnet3: make descriptor count checks more robust (authored by kp).
vmxnet3: make descriptor count checks more robust
Mon, Jun 10, 9:06 AM

Sat, Jun 8

kp committed rGba2a92078626: pf: convert DIOCBEGINADDRS to netlink (authored by kp).
pf: convert DIOCBEGINADDRS to netlink
Sat, Jun 8, 2:48 AM

Fri, Jun 7

kp committed rGd9ab89993138: pf: migrate DIOCGETLIMIT/DIOCSETLIMIT to netlink (authored by kp).
pf: migrate DIOCGETLIMIT/DIOCSETLIMIT to netlink
Fri, Jun 7, 7:15 PM
kp committed rGea6d6addc9bc: pf.conf.5: remove 'set limit tables' (authored by kp).
pf.conf.5: remove 'set limit tables'
Fri, Jun 7, 7:15 PM
kp accepted D45533: pfsync: Correctly check if bpf peers are present.
Fri, Jun 7, 6:08 PM
kp accepted D45532: pflog: Correctly check if bpf peers are present.
Fri, Jun 7, 5:27 PM

Thu, Jun 6

kp committed rGf042e1515433: pf: add sctp multihome probe points (authored by kp).
pf: add sctp multihome probe points
Thu, Jun 6, 8:41 PM
kp committed rG30bad751e8bf: pf: convert DIOCGETTIMEOUT/DIOCSETTIMEOUT to netlink (authored by kp).
pf: convert DIOCGETTIMEOUT/DIOCSETTIMEOUT to netlink
Thu, Jun 6, 8:41 PM
kp committed rG8ed5170c66ec: pf tests: test setting and retrieving timeout values (authored by kp).
pf tests: test setting and retrieving timeout values
Thu, Jun 6, 8:41 PM
kp committed rGb5b90ff9844d: u3g: Add support for SIM7600G (authored by Maxime Thiebaut <maxime+freebsd@thiebaut.dev>).
u3g: Add support for SIM7600G
Thu, Jun 6, 3:07 PM
kp accepted D45509: bpf: Make bpf_peers_present a boolean inline function.
Thu, Jun 6, 1:47 PM
kp committed rGdc3ee89c86d3: pfctl: fix possible out-of-bounds read (authored by kp).
pfctl: fix possible out-of-bounds read
Thu, Jun 6, 1:46 PM
kp committed rG8f04209d37ec: pf: simplify pf_addrcpy() and pf_match_addr() (authored by kp).
pf: simplify pf_addrcpy() and pf_match_addr()
Thu, Jun 6, 1:46 PM
kp committed rGf0829825fb9d: netlink: pass the correct arguments for SIOCDIFADDR and SIOCDIFADDR_IN6 (authored by kp).
netlink: pass the correct arguments for SIOCDIFADDR and SIOCDIFADDR_IN6
Thu, Jun 6, 1:46 PM
kp committed rG8ca12190bf66: pf: remove incorrect SUNION2PF() macro (authored by kp).
pf: remove incorrect SUNION2PF() macro
Thu, Jun 6, 1:46 PM

Tue, Jun 4

kp committed rG480ad4055314: vnet tests: check for if_bridge.ko (authored by kp).
vnet tests: check for if_bridge.ko
Tue, Jun 4, 8:53 PM
kp closed D45487: vnet tests: check for if_bridge.ko.
Tue, Jun 4, 8:53 PM
kp added inline comments to D45487: vnet tests: check for if_bridge.ko.
Tue, Jun 4, 8:16 PM
kp requested review of D45487: vnet tests: check for if_bridge.ko.
Tue, Jun 4, 8:02 PM
kp committed rG84ff9e9122ac: pf: fix overly large memcpy() (authored by kp).
pf: fix overly large memcpy()
Tue, Jun 4, 5:45 PM
kp committed rG4779b16fa61f: pf: fix overly large copy in pf_rule_to_krule() (authored by kp).
pf: fix overly large copy in pf_rule_to_krule()
Tue, Jun 4, 5:45 PM
kp accepted D45476: mfi: default to using mrsas(4) for newer cards.

This causes my Dell T640 boxes to use the mrsas driver without having to explicitly set the loader.conf variable (as I was doing previously), so as far as I'm concerned this is an improvement.

Tue, Jun 4, 3:27 PM
kp committed rG2144e31d8f85: netpfil tests: make the pls tests more robust (authored by kp).
netpfil tests: make the pls tests more robust
Tue, Jun 4, 3:00 PM
kp committed rG1c5b886e1116: pf tests: make ether:dummynet test a little more robust (authored by kp).
pf tests: make ether:dummynet test a little more robust
Tue, Jun 4, 3:00 PM
kp committed rGcce69517551d: pf tests: basic debug level test (authored by kp).
pf tests: basic debug level test
Tue, Jun 4, 3:00 PM
kp committed rGa9d7ff4e5e6d: pf tests: basic status get/clear test (authored by kp).
pf tests: basic status get/clear test
Tue, Jun 4, 3:00 PM
kp committed rGc36c90a2cc17: pf: convert DIOCSETDEBUG to netlink (authored by kp).
pf: convert DIOCSETDEBUG to netlink
Tue, Jun 4, 3:00 PM
kp committed rG71d3c7041d70: pf: convert DIOCNATLOOK to netlink (authored by kp).
pf: convert DIOCNATLOOK to netlink
Tue, Jun 4, 3:00 PM
kp committed rG9dbbe68bc5f2: pf: convert DIOCCLRSTATUS to netlink (authored by kp).
pf: convert DIOCCLRSTATUS to netlink
Tue, Jun 4, 3:00 PM

Fri, May 31

kp requested review of D45428: cxgbe: handle vlan PF restrictions.
Fri, May 31, 7:53 PM
kp requested review of D45427: mlx5: handle vlan PF restrictions.
Fri, May 31, 7:52 PM
kp updated the diff for D45402: iovctl: allow vlan restrictions to be passed to the driver.
  • Move driver changes into separate commits
  • support 'vlan: trunk;', indicating there's no vlan filtering For this we pass vlan id 4096, which drivers translate into meaning 'no vlan acl'. This allows drivers that can handle it to use vlan id 0 to mean 'vlan header, but logically untagged'.
Fri, May 31, 7:51 PM
kp added inline comments to D45402: iovctl: allow vlan restrictions to be passed to the driver.
Fri, May 31, 2:40 PM
kp added a comment to D45406: pci: Consistently use pci_vf_* for suballocated VF memory resources.

This version resolves the panic I saw.

Fri, May 31, 2:27 PM

Thu, May 30

kp added a comment to D45406: pci: Consistently use pci_vf_* for suballocated VF memory resources.

I still see a panic (on the host) when I kldload if_cxgbev in a bhyve guest that has a VF passed to it:

Thu, May 30, 1:52 PM
kp accepted D45405: pci: Use kobj typedefs for new-bus method prototypes.
Thu, May 30, 1:49 PM

Wed, May 29

kp added a comment to D45402: iovctl: allow vlan restrictions to be passed to the driver.

I've not been able to test the mxl5 changes as I don't have access to the hardware.

Wed, May 29, 8:29 PM
kp requested review of D45402: iovctl: allow vlan restrictions to be passed to the driver.
Wed, May 29, 8:27 PM

Tue, May 28

kp committed rG8b28ec3861d5: pf tests: test longer anchor names (authored by kp).
pf tests: test longer anchor names
Tue, May 28, 8:32 PM
kp committed rG8ddd0359bca5: pfctl: fix recursive printing of nat anchors (authored by kp).
pfctl: fix recursive printing of nat anchors
Tue, May 28, 8:31 PM
kp committed rG6ee3e376823f: pf: fix incorrect anchor_call to userspace (authored by kp).
pf: fix incorrect anchor_call to userspace
Tue, May 28, 8:31 PM
kp committed rGcd2054d48bc6: libpfctl: add pfctl_get_rule_h() (authored by kp).
libpfctl: add pfctl_get_rule_h()
Tue, May 28, 8:31 PM

Sun, May 26

kp committed rG76bc4a776fac: pfctl: use pfctl_add_rule_h() rather than pfctl_add_rule() (authored by kp).
pfctl: use pfctl_add_rule_h() rather than pfctl_add_rule()
Sun, May 26, 11:27 PM

Wed, May 22

kp closed D45285: if_vlan: handle VID conflicts.
Wed, May 22, 7:42 AM
kp committed rGbdd12889eaa6: if_vlan: handle VID conflicts (authored by kp).
if_vlan: handle VID conflicts
Wed, May 22, 7:42 AM

Tue, May 21

kp added a comment to D45283: ifconfig: redo fix vlan/vlanproto reconfiguration.

@kp I'm going to commit this if no objections.

No objection. Go ahead and commit.

Tue, May 21, 3:57 PM
kp added inline comments to D45285: if_vlan: handle VID conflicts.
Tue, May 21, 2:34 PM
kp accepted D45283: ifconfig: redo fix vlan/vlanproto reconfiguration.

I've fixed the other vlan issue in https://reviews.freebsd.org/D45285.

Tue, May 21, 12:29 PM
kp requested review of D45285: if_vlan: handle VID conflicts.
Tue, May 21, 12:25 PM
kp added a comment to D45283: ifconfig: redo fix vlan/vlanproto reconfiguration.
diff --git a/tests/sys/net/if_vlan.sh b/tests/sys/net/if_vlan.sh
index 675ed0090e8c..4d5d70410898 100755
--- a/tests/sys/net/if_vlan.sh
+++ b/tests/sys/net/if_vlan.sh
@@ -37,7 +37,7 @@ basic_body()
        # And change back
        # Test changing the vlan ID
        atf_check -s exit:0 \
-           jexec singsing ifconfig ${vlan1} vlandev ${epair_vlan}b vlan 42
+           jexec singsing ifconfig ${vlan1} vlan 42 vlandev ${epair_vlan}b
        atf_check -s exit:0 -o ignore jexec singsing ping -c 1 10.0.0.1
 }
Tue, May 21, 11:28 AM

Mon, May 20

kp committed rG18c38eda39bb: if_ovpn: cope with loops (authored by kp).
if_ovpn: cope with loops
Mon, May 20, 7:58 AM
kp committed rGfecd30388256: if: guard against if_ioctl being NULL (authored by kp).
if: guard against if_ioctl being NULL
Mon, May 20, 7:40 AM

Thu, May 16

kp committed rGb9f6b6685558: pf: always mark states as unlinked before detaching them (authored by kp).
pf: always mark states as unlinked before detaching them
Thu, May 16, 12:03 PM
kp committed rGe73147fc7ca6: pf: always mark states as unlinked before detaching them (authored by kp).
pf: always mark states as unlinked before detaching them
Thu, May 16, 12:02 PM

May 15 2024

kp added a comment to D44488: pf: if a new RDR state connect be created, modulate src port.

but with this change we are implicitly rewriting the source port. What explicit mechanism is the man page alluding to here?

That'd be things like rdr on $ext_if proto tcp from any to any port 80 -> 127.0.0.1 port 8080, where we redirect incoming connections on port 80 to localhost port 8080.
When we're doing explicit rewrites it's always going to be the destination port, of course.

May 15 2024, 10:07 AM

May 14 2024

kp accepted D45197: if_vxlan(4): Add checking for nesting of tunnels.

I'm not sure I'd have bothered to make the nesting level configurable, but now that you've done the work it'd be silly to not use it.

May 14 2024, 10:42 AM
kp accepted D45196: mlx4, mlx5: Eliminate redundent check for NULL packet filter.

The referenced commit (2b9600b4497b) seems to be relevant for the detach flow, but it doesn't guarantee there will an if_bpf pointer when a struct ifnet is created.
However, ether_ifattach() does an unconditional bpfattach(), so I think this is still correct (given that mlx* are Ethernet devices).

May 14 2024, 8:14 AM

May 13 2024

kp committed rG14c2c7913c90: libpfctl: fix incorrect pcounters array size (authored by kp).
libpfctl: fix incorrect pcounters array size
May 13 2024, 3:44 PM
kp committed rG75a94658d372: libpfctl: fix incorrect pcounters array size (authored by kp).
libpfctl: fix incorrect pcounters array size
May 13 2024, 3:43 PM
kp committed rG59a6666ec91d: if_ovpn: cope with loops (authored by kp).
if_ovpn: cope with loops
May 13 2024, 10:12 AM

May 12 2024

kp committed rG9a8a26aefb36: if: guard against if_ioctl being NULL (authored by kp).
if: guard against if_ioctl being NULL
May 12 2024, 4:13 PM

May 9 2024

kp committed rGf1612e7087d7: libpfctl: fix file descriptor leak (authored by kp).
libpfctl: fix file descriptor leak
May 9 2024, 12:10 PM

May 8 2024

kp closed D45101: pf: always mark states as unlinked before detaching them.
May 8 2024, 11:23 AM
kp committed rG301ec2cebb6a: pf: always mark states as unlinked before detaching them (authored by kp).
pf: always mark states as unlinked before detaching them
May 8 2024, 11:22 AM
kp committed rG0d446a4303a8: carp: document the new VRRPv3 support (authored by kp).
carp: document the new VRRPv3 support
May 8 2024, 11:22 AM
kp closed D44776: carp: document the new VRRPv3 support.
May 8 2024, 11:22 AM
kp committed rG5311e7333714: netinet tests: basic VRRP tests (authored by kp).
netinet tests: basic VRRP tests
May 8 2024, 11:21 AM
kp closed D44775: netinet tests: basic VRRP tests.
May 8 2024, 11:21 AM
kp committed rGa254d6870e88: carp: isolate VRRP from CARP (authored by glebius).
carp: isolate VRRP from CARP
May 8 2024, 11:21 AM
kp closed D45039: carp: isolate VRRP from CARP.
May 8 2024, 11:21 AM
kp committed rG601438fbfa8e: carp: refactor packet tagging for ether_output() (authored by glebius).
carp: refactor packet tagging for ether_output()
May 8 2024, 11:21 AM
kp closed D45038: carp: refactor packet tagging for ether_output().
May 8 2024, 11:21 AM
kp committed rGcda57d955b25: carp: assert that we are calling correct input function. We are. (authored by glebius).
carp: assert that we are calling correct input function. We are.
May 8 2024, 11:21 AM
kp closed D45037: carp: assert that we are calling correct input function. We are..
May 8 2024, 11:20 AM
kp committed rG5ee92cbd82d0: carp: don't chain call vrrp_send_ad via carp_send_ad (authored by glebius).
carp: don't chain call vrrp_send_ad via carp_send_ad
May 8 2024, 11:20 AM
kp closed D45036: carp: don't chain call vrrp_send_ad via carp_send_ad.
May 8 2024, 11:20 AM
kp committed rG37115154672f: carp: support VRRPv3 (authored by kp).
carp: support VRRPv3
May 8 2024, 11:20 AM
kp closed D44774: carp: support VRRPv3.
May 8 2024, 11:20 AM

May 7 2024

kp added a comment to D44774: carp: support VRRPv3.

My personal suggestion: it's worth to mention it in carp(4), and perhaps even adding a link of vrrp(4)

May 7 2024, 9:22 PM
kp added a comment to D44774: carp: support VRRPv3.

Last call for objections. I intend to commit tomorrow.

May 7 2024, 4:10 PM

May 6 2024

kp requested review of D45101: pf: always mark states as unlinked before detaching them.
May 6 2024, 2:51 PM
kp committed rG43387b4e5740: if: guard against if_ioctl being NULL (authored by kp).
if: guard against if_ioctl being NULL
May 6 2024, 1:26 PM

May 4 2024

kp added a comment to D44774: carp: support VRRPv3.
In D44774#1028213, @bz wrote:
In D44774#1027883, @kp wrote:
In D44774#1027778, @bz wrote:

(2) We are adding to but not fixing the problem of the conflicting version number; it's easy to say I can add v3 but ... see (1).

As in carpv3? That seems entirely unlikely to ever happen, given that carp's entire reason for existing is now moot.

No, as in carp getting an official version number.

I'm not sure I follow. Do you mean carp might be officially designated vrrp version 9 (let's say)? That seems both very unlikely, and something that wouldn't actually be a problem to deal with. We already distinguish vrrpv3 from carp by the version number, so looking for version 9 would, if anything, make things easier.

May 4 2024, 10:42 AM

May 3 2024

kp committed R11:d1fae9f59f5f: net/libpfctl: support FreeBSD 14.1 (authored by kp).
net/libpfctl: support FreeBSD 14.1
May 3 2024, 1:27 PM
kp updated the diff for D44774: carp: support VRRPv3.

review remarks

May 3 2024, 11:39 AM