Details

Reviewers

markj
emaste
dev_submerge.ch
bapt

Commits

rGd1eaefde3bca: sound: Remove hw.snd.version and SND_DRV_VERSION
rG7398d1ece5cf: sound: Remove hw.snd.version and SND_DRV_VERSION

Summary

hw.snd.version and SND_DRV_VERSION define the sound driver version and
are meant to be used in bug reports, but because these values are
constant, there is not much useful information we can extract from them.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Sun, Apr 28, 5:22 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Apr 28, 5:22 PM

christos requested review of this revision.Sun, Apr 28, 5:22 PM

christos added a child revision: D44997: sound: Move chip.h contents to pcm/sound.h.

Harbormaster completed remote builds in B57430: Diff 137783.Sun, Apr 28, 5:22 PM

christos retitled this revision from sound: Move SND_DRV_VERSION to pcm/sound.h to sound: Remove hw.snd.version and SND_DRV_VERSION.Mon, Apr 29, 12:21 PM

christos edited the summary of this revision. (Show Details)

christos added a reviewer: dev_submerge.ch.

Remove it.

Harbormaster completed remote builds in B57445: Diff 137835.Mon, Apr 29, 12:23 PM

christos added a reviewer: bapt.Mon, Apr 29, 12:23 PM

Remove "%ubit" line from sbuf_printf() in sndstat.c, MACHINE_ARCH includes the
bits already.

Harbormaster completed remote builds in B57446: Diff 137839.Mon, Apr 29, 12:27 PM

Looks reasonable - I think it was addressing an issue that does not really exist now.

sys/dev/sound/pcm/sndstat.c
1273–1275	is even this useful? MACHINE_ARCH is certainly emitted somewhere else already

dev_submerge.ch added inline comments.Mon, Apr 29, 1:36 PM

sys/dev/sound/pcm/sndstat.c
1273–1275	is even this useful? MACHINE_ARCH is certainly emitted somewhere else already Depends on whether we expect people to always provide `uname -a` in bug reports. I think the revision of FreeBSD could be more helpful here, as in `14.0-RELEASE-p6`, or even commit level for CURRENT if we can get those easily.

christos added inline comments.Mon, Apr 29, 2:48 PM

sys/dev/sound/pcm/sndstat.c
1273–1275	is even this useful? MACHINE_ARCH is certainly emitted somewhere else already It isn't emitted anywhere else in sound(4) at least, but I do not think it hurts to include it in the sndstat header. Depends on whether we expect people to always provide `uname -a` in bug reports. I think the revision of FreeBSD could be more helpful here, as in `14.0-RELEASE-p6`, or even commit level for CURRENT if we can get those easily. I guess a more accurate way would be to provide the latest sound(4)-related commit hash, along with the FreeBSD revision, but I am not sure if we need to provide this information from sound(4) itself.

markj added inline comments.Tue, Apr 30, 12:13 AM

sys/dev/sound/pcm/sndstat.c
1273–1275	I think users are generally good about providing version info these days (and if they aren't, this isn't going to help). I don't see any reason to duplicate it.