Page MenuHomeFreeBSD

network.subr: Remove extraneous checkyesno synchronous_dhclient
AbandonedPublic

Authored by cy on Thu, Apr 25, 7:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 1:18 PM
Unknown Object (File)
Sun, May 5, 8:21 PM
Unknown Object (File)
Sun, Apr 28, 8:36 PM
Unknown Object (File)
Fri, Apr 26, 7:30 PM
Unknown Object (File)
Fri, Apr 26, 7:30 PM
Unknown Object (File)
Fri, Apr 26, 3:55 PM
Subscribers
None

Details

Reviewers
imp
bz
Summary

checkyesno outside of an if construct makes no sense.

Fixes: 5d595cb88eaa

Test Plan

Tested locally.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

cy requested review of this revision.Thu, Apr 25, 7:53 PM
cy created this revision.

Why not? Is that not just passing the result back to the caller at the end of the shell function?
Given I have to ask this, I am probably not the right one to review...

In D44960#1024991, @bz wrote:

Why not? Is that not just passing the result back to the caller at the end of the shell function?
Given I have to ask this, I am probably not the right one to review...

That is indeed what it's doing.