Page MenuHomeFreeBSD
Differential D44886

ktrace: Describe CAPFAIL trace point in man page
ClosedPublic
Actions

Authored by jfree on Sat, Apr 20, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 7:35 AM
Unknown Object (File)
Fri, Apr 26, 9:18 PM
Unknown Object (File)
Fri, Apr 26, 3:51 PM
Unknown Object (File)
Fri, Apr 26, 3:51 PM
Unknown Object (File)
Fri, Apr 26, 3:51 PM
Unknown Object (File)
Fri, Apr 26, 3:51 PM
Unknown Object (File)
Fri, Apr 26, 10:32 AM
Unknown Object (File)
Fri, Apr 26, 1:17 AM
View All 9 Files
Subscribers
imp
jonathan

Details

Reviewers
markj
Commits
rG4f2ada0d8821: ktrace: Describe CAPFAIL trace point in man page
Summary

Update the ktrace(1) man page to describe the recently improved
capability failure tracing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jfree created this revision.Sat, Apr 20, 5:44 PM
Herald added subscribers: jonathan, imp. · View Herald TranscriptSat, Apr 20, 5:44 PM
jfree requested review of this revision.Sat, Apr 20, 5:44 PM
Harbormaster completed remote builds in B57247: Diff 137442.Sat, Apr 20, 5:44 PM
jfree added a child revision: D44887: ktrace: Remove CAPFAIL from default trace points.Sat, Apr 20, 5:45 PM
markj added inline comments.Sun, Apr 21, 3:05 PM
usr.bin/ktrace/ktrace.1
159

You should reference capsicum.4 here somehow.

161

This wording is a bit confusing to me: I think it could be simplified with something like, "Violations are logged regardless of whether the process has actually entered capability mode."

165

Maybe note that it's more useful when combined with "c".

167

Well, the number of log entries is a pretty weak indicator.

jfree updated this revision to Diff 137476.Mon, Apr 22, 3:34 AM
jfree marked 4 inline comments as done.

Address Mark's comments

markj accepted this revision.Mon, Apr 22, 1:26 PM

Nice, looks good.

This revision is now accepted and ready to land.Mon, Apr 22, 1:26 PM
Closed by commit rG4f2ada0d8821: ktrace: Describe CAPFAIL trace point in man page (authored by jfree). · Explain WhyWed, Apr 24, 12:29 AM
This revision was automatically updated to reflect the committed changes.
jfree added a commit: rG4f2ada0d8821: ktrace: Describe CAPFAIL trace point in man page.

Revision Contents
Changeset List

PathSize
usr.bin/
ktrace/
20 lines

Diff 137590

View Options

usr.bin/ktrace/ktrace.1

Loading...