sound: Remove obsolete DV_F_* flags
ClosedPublic
Actions

Authored by christos on Apr 18 2024, 6:48 PM.

Details

Reviewers

markj
emaste

Commits

rG41dee6355556: sound: Remove obsolete DV_F_* flags
rG1b82d425ec0a: sound: Remove obsolete DV_F_* flags

Summary

The ISA sound drivers that used them are retired.

Last reference of DV_F_DRQ_MASK and DV_F_DUAL_DMA:
716924cb4832ea0a440daf09913a06f3166f243e ("Retire snd_sbc ISA sound card
driver")

Last reference of DV_F_DEV_MASK and DV_F_DEV_SHIFT:
5126e5eeeb5e07ceef3c809452a8c9f508b2d4d1 ("Retire snd_mss ISA sound card
driver")

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Apr 18 2024, 6:48 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 18 2024, 6:48 PM

christos requested review of this revision.Apr 18 2024, 6:48 PM

Harbormaster completed remote builds in B57204: Diff 137356.Apr 18 2024, 6:48 PM

christos retitled this revision from sound: Remove obsolete flags to sound: Remove obsolete DV_F_* flags.Apr 18 2024, 6:48 PM

If it's not too much trouble it would be good to link to the commit that removed the last reference, or maybe just mention "...the ISA sound drivers that...". (I assume it is the ISA drivers I removed that were the consumers of these flags.)

This revision is now accepted and ready to land.Apr 18 2024, 6:53 PM

In D44858#1022641, @emaste wrote:

If it's not too much trouble it would be good to link to the commit that removed the last reference, or maybe just mention "...the ISA sound drivers that...". (I assume it is the ISA drivers I removed that were the consumers of these flags.)

No problem.

christos edited the summary of this revision. (Show Details)Apr 18 2024, 6:59 PM

markj accepted this revision.Apr 18 2024, 7:03 PM

Closed by commit rG1b82d425ec0a: sound: Remove obsolete DV_F_* flags (authored by christos). · Explain WhyApr 18 2024, 8:36 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG1b82d425ec0a: sound: Remove obsolete DV_F_* flags.

christos added a commit: rG41dee6355556: sound: Remove obsolete DV_F_* flags.Fri, May 17, 7:32 PM