sound: Be more verbose with virtual channel descriptions
ClosedPublic
Actions

Authored by christos on Thu, Apr 18, 5:31 PM.

Details

Reviewers

markj
emaste

Commits

rGd0032e6a9e65: sound: Be more verbose with virtual channel descriptions

Summary

Non-virtual channel description denote "play" or "record", so do the
same for virtual ones as well.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Test Plan

Before:

root@freebsd:/mnt/src # cat /dev/sndstat | grep pcm0:
pcm0: <Focusrite Scarlett Solo USB> on uaudio0 (1p:1v/1r:1v) default
        [pcm0:play:dsp0.p0]: spd 48000, fmt 0x00200010/0x00201000, flags 0x00002100, 0x00000006
        pcm0:play:dsp0.p0[pcm0:virtual:dsp0.vp0]: spd 8000, fmt 0x00100008, flags 0x10000000, 0x00000000
        [pcm0:record:dsp0.r0]: spd 48000, fmt 0x00200010/0x00201000, flags 0x00002100, 0x00000007
        pcm0:record:dsp0.r0[pcm0:virtual:dsp0.vr0]: spd 8000, fmt 0x00100008, flags 0x10000000, 0x00000000

After:

root@freebsd:/mnt/src # cat /dev/sndstat | grep pcm0:
pcm0: <Focusrite Scarlett Solo USB> on uaudio0 (1p:1v/1r:1v) default
        [pcm0:play:dsp0.p0]: spd 48000, fmt 0x00200010/0x00201000, flags 0x00002100, 0x00000006
        pcm0:play:dsp0.p0[pcm0:virtual_play:dsp0.vp0]: spd 8000, fmt 0x00100008, flags 0x10000000, 0x00000000
        [pcm0:record:dsp0.r0]: spd 48000, fmt 0x00200010/0x00201000, flags 0x00002100, 0x00000007
        pcm0:record:dsp0.r0[pcm0:virtual_record:dsp0.vr0]: spd 8000, fmt 0x00100008, flags 0x10000000, 0x00000000

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Thu, Apr 18, 5:31 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Apr 18, 5:31 PM

christos requested review of this revision.Thu, Apr 18, 5:31 PM

Harbormaster completed remote builds in B57178: Diff 137317.Thu, Apr 18, 5:31 PM

christos edited the test plan for this revision. (Show Details)Thu, Apr 18, 5:33 PM

I don't object but we already have :record: or :play: (elsewhere) in the description, is there any case where this won't be the case?

In D44839#1022562, @emaste wrote:

I don't object but we already have :record: or :play: (elsewhere) in the description, is there any case where this won't be the case?

There are many places where we print the channel name (search for ch->name or c->name) and in this case the strings will only contain :virtual:.

markj accepted this revision.Thu, Apr 18, 8:07 PM

This revision is now accepted and ready to land.Thu, Apr 18, 8:07 PM

emaste accepted this revision.Thu, Apr 18, 8:10 PM

Closed by commit rGd0032e6a9e65: sound: Be more verbose with virtual channel descriptions (authored by christos). · Explain WhyThu, Apr 18, 8:36 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGd0032e6a9e65: sound: Be more verbose with virtual channel descriptions.