Page MenuHomeFreeBSD

libfetch: parse scheme://domain:/ correctly
ClosedPublic

Authored by khng on Mar 25 2024, 5:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 5:21 PM
Unknown Object (File)
Fri, May 10, 5:20 PM
Unknown Object (File)
Fri, May 10, 5:19 PM
Unknown Object (File)
Mon, May 6, 9:43 AM
Unknown Object (File)
Mar 27 2024, 6:00 PM
Unknown Object (File)
Mar 25 2024, 8:14 PM
Subscribers

Details

Summary

This improves URL-parsing compability with cURL, and unbreaks parsing of
similar kinds of URLs after commit 8d9de5b10a24.

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng requested review of this revision.Mar 25 2024, 5:01 AM

Can you please provide an example of a URL which is parsed incorrectly without this patch?

@des something like https://example.com:/ used to work before https://reviews.freebsd.org/rG8d9de5b10a24bd2d79ed99f139c0ac28c09b15ca. Meanwhile, curl -L https://example.com:/ gives the HTML page just as curl -L https://example.com/, and is true for Firefox and Chromium-based browsers as well.

This revision is now accepted and ready to land.Mar 25 2024, 5:49 PM
This revision was automatically updated to reflect the committed changes.