icmp: when logging ICMP ratelimiting message use correct jitter value
ClosedPublic
Actions

Authored by glebius on Mar 22 2024, 9:49 PM.

Details

Reviewers

kp
tuexen
zlei

Group Reviewers

network

Commits

rGb508545ce044: icmp: when logging ICMP ratelimiting message use correct jitter value

Summary

The limiting of the very last second has been done using certain jitter
value. We update the jitter for the next second. But the logging should
report the jitter before the change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mar 22 2024, 9:49 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptMar 22 2024, 9:49 PM

glebius requested review of this revision.Mar 22 2024, 9:49 PM

Harbormaster completed remote builds in B56748: Diff 136106.Mar 22 2024, 9:49 PM

glebius added a parent revision: D44476: icmp: hide icmp_bandlimit_uninit() under VIMAGE.Mar 22 2024, 9:49 PM

glebius added a child revision: D44478: icmp: improve ICMP limit jitter.

glebius added a reviewer: kp.Mar 22 2024, 9:56 PM

kp accepted this revision as: kp.Mar 23 2024, 3:38 AM

This revision is now accepted and ready to land.Mar 23 2024, 3:38 AM

tuexen accepted this revision.Mar 23 2024, 2:17 PM

Looks good to me.

Closed by commit rGb508545ce044: icmp: when logging ICMP ratelimiting message use correct jitter value (authored by glebius). · Explain WhyMar 24 2024, 4:21 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGb508545ce044: icmp: when logging ICMP ratelimiting message use correct jitter value.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_icmp.c

10 lines

Diff 136161

View Options

icmp: when logging ICMP ratelimiting message use correct jitter valueClosedPublicActions