uart: Split out initilisation of the acpi devinfo
ClosedPublic
Actions

Authored by andrew on Mar 14 2024, 4:49 PM.

Details

Reviewers

cperciva
imp

Commits

rG473c0b44ae8c: uart: Split out initilisation of the acpi devinfo

Summary

Split out the common parts of building the uart devinfo from ACPI
tables from the SPCR parser. This will be used when we support the DBG2
table to find the debug uart to be used by the kernel gdb stub.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew requested review of this revision.Mar 14 2024, 4:49 PM

andrew created this revision.

Harbormaster completed remote builds in B56603: Diff 135754.Mar 14 2024, 4:49 PM

andrew added a child revision: D44358: uart: Add uart_cpu_acpi_setup to setup the uart.Mar 14 2024, 4:50 PM

just one (possibly unrelated) question.

sys/dev/uart/uart_cpu_acpi.c
130	surely this should be 4? I know this is already there, but it looks out of place.

This revision is now accepted and ready to land.Mar 14 2024, 5:53 PM

andrew added inline comments.Mar 14 2024, 5:59 PM

sys/dev/uart/uart_cpu_acpi.c
130	It's a shift, so `1<<3` is 8 bytes or 64 bits

Closed by commit rG473c0b44ae8c: uart: Split out initilisation of the acpi devinfo (authored by andrew). · Explain WhyMar 18 2024, 4:38 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG473c0b44ae8c: uart: Split out initilisation of the acpi devinfo.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_cpu_acpi.c

86 lines

Diff 135893

View Options

sys/dev/uart/uart_cpu_acpi.c

uart: Split out initilisation of the acpi devinfoClosedPublicActions