Deep copy tls_enable struct in copyin_tls_enable

[rscheff]

Summary

Doing a deep copy of the keys early allows users of the tls_enable structure to assume kernel memory.
This also enables the socket options to be set by kernel threads.

Taking over the commit process from cmiller_netapp.com after internal coordination.

Sponsored by: NetApp, Inc.
X-NetApp-PR: #79

[rscheff]

sys/kern/uipc_ktls.c

380

in ktls_destroy(), all crypto material is purged before freeing, by using zfree(). It would be prudent to do the same here for all these crypto keys.

[rscheff]

• clean before free all crypto material

[rscheff]

• clean key material in the error path too.

[jhb]

The use of zfree is fine and is the intended use case.

sys/kern/uipc_ktls.c

331

Should really be if (error != 0) in new code here and elsewhere.

366

Should check pointers against NULL explicitly, however, free(9) (just like free(3) in userland) handles NULL pointers just fine, so I would just remove all the checks and call zfree unconditionally instead.

sys/sys/ktls.h

216

I don't think you need the blank line after these, but they should be sorted alphabetically to match the rest of the prototypes. I would also probably add a ktls_ prefix to these two functions since the rest of the exported (public) API from uipc_ktls.c uses that prefix.

[rscheff]

• sort prototype definitions alphabetically

[rscheff]

addressed all comments.