Page MenuHomeFreeBSD

bsdconfig: Add `network' keyword
ClosedPublic

Authored by dteske on Oct 16 2023, 11:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 1:37 PM
Unknown Object (File)
Tue, Apr 30, 1:37 PM
Unknown Object (File)
Tue, Apr 30, 1:37 PM
Unknown Object (File)
Tue, Apr 30, 1:37 PM
Unknown Object (File)
Tue, Apr 30, 7:16 AM
Unknown Object (File)
Mar 9 2024, 11:44 AM
Unknown Object (File)
Jan 4 2024, 6:37 PM
Unknown Object (File)
Dec 23 2023, 2:53 AM

Details

Summary

Configuring a FreeBSD laptop, my fingers kept wanting to type
`bsdconfig network' and I could not figure out why this was not working.
Took me a second to realize that the shortcut was `bsdconfig networking'
for where I wanted to go.

Add a `network' keyword so that my fingers are not wrong when they try
and type `bsdconfig network' and make it go where to the same place as
`bsdconfig networking'.

Test Plan
  1. Execute `bsdconfig network'
  2. Make sure it goes the same place as `bsdconfig networking'

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

FYI for future Phabricator uploads please include full context, e.g. git show -U99999 <hash>. Details are at https://wiki.freebsd.org/action/show/Phabricator

FYI for future Phabricator uploads please include full context, e.g. git show -U99999 <hash>. Details are at https://wiki.freebsd.org/action/show/Phabricator

With all due respect, with the FreeBSD laptop that I am using right now, that's going to take me 5 times longer.

But because you need it, I will go ahead and copy a portion of the text on the small XTerm that I am using, middle click in the Firefox window to paste a portion of the full-context diff, go back to XTerm, painstakingly scroll with the middle mouse button, painstakingly try and not mis-click, select the next hunk of context, painstakingly navigate the mouse back to Firefox, very carefully ...

Patience, I'll get you the context you need.

Full context as-requested by emaste

It's not that I need it, it's just the standard, documented way we use Phabricator in FreeBSD. We ask for that so reviewers can see the context, if desired. There's no need to cut and paste, just git show -U99999 <hash> > whatever.patch and upload that to Phab (see "Create a Revision via Web Interface" in the wiki page).

For future reference, I find the git arc tool (in src/tools/tools/git) a better way to interact with phab than having to upload patches manually. You can just 'git commit' and then 'git arc create HEAD'. The latter command creates a review using the log message to populate the title and description, etc. There is a manpage that gives more examples of how to add reviewers when creating a review, updating a review when you update the patch locally, and how to stage the commit once the review is approved to automatically add the right metadata to the commit log before pushing the final change.

This revision is now accepted and ready to land.Oct 17 2023, 5:34 PM
This revision was automatically updated to reflect the committed changes.