syslogd: Simplify property filters
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:30 PM.

Details

Reviewers

markj
emaste

Commits

rGfcc1e1777d42: syslogd: Simplify property filters

Summary

Use enums for property filter properties and comparisons.
Rename property and comparison values.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jfree created this revision.Aug 8 2023, 3:30 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:30 PM

jfree requested review of this revision.Aug 8 2023, 3:30 PM

jfree added a parent revision: D41365: syslogd: Clean up allowedpeer structure.

jfree added a child revision: D41367: syslogd: Style fixes.

Because C enums are integer-sized, this makes struct prop_filter a bit fatter, but that's ok.

usr.sbin/syslogd/syslogd.c
237	FILT_CMP_* now starts from 0 instead of 1, but I think that's fine...
1571	This can be: default: __unreachable(); (FILT_CMP_REGEX is handled above.)

This revision is now accepted and ready to land.Aug 9 2023, 7:21 PM

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:10 PM

markj accepted this revision.Aug 11 2023, 2:50 PM

This revision is now accepted and ready to land.Aug 11 2023, 2:50 PM

Closed by commit rGfcc1e1777d42: syslogd: Simplify property filters (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:53 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGfcc1e1777d42: syslogd: Simplify property filters.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

syslogd.c

101 lines

Diff 127942

View Options

usr.sbin/syslogd/syslogd.c

syslogd: Simplify property filtersClosedPublicActions