xargs: Avoid a possible multiplication overflow

[jlduran_gmail.com]

Summary

Use calloc() instead of malloc() to avoid a possible multiplication overflow.

---

NB: This was the cheapest way I was able to make the test introduced in eab91d008165e7bbf8ca7b87eabe4dc8bf3da191 pass.

Test Plan

# kyua debug legacy_test:main
1..22
ok - normal # Test detected no regression. (in .)
ok - I # Test detected no regression. (in .)
ok - J # Test detected no regression. (in .)
ok - L # Test detected no regression. (in .)
ok - P1 # Test detected no regression. (in .)
ok - R # Test detected no regression. (in .)
ok - R-1 # Test detected no regression. (in .)
ok - n1 # Test detected no regression. (in .)
ok - n2 # Test detected no regression. (in .)
ok - n2147483647 # Test detected no regression. (in .)
ok - n2P0 # Test detected no regression. (in .)
ok - n3 # Test detected no regression. (in .)
ok - 0 # Test detected no regression. (in .)
ok - 0I # Test detected no regression. (in .)
ok - 0J # Test detected no regression. (in .)
ok - 0L # Test detected no regression. (in .)
ok - 0P1 # Test detected no regression. (in .)
ok - quotes # Test detected no regression. (in .)
ok - parallel1 # Test detected no regression. (in .)
ok - parallel2 # Test detected no regression. (in .)
ok - parallel3 # Test detected no regression. (in .)
ok - parallel4 # Test detected no regression. (in .)
legacy_test:main  ->  passed

[markj]

usr.bin/xargs/xargs.c

261

The problem is here, and it's triggered by xargs -n 2147483647. That causes xargs to allocate 16GB of RAM.

The problem is that with malloc(), by default, jemalloc will fill the allocated memory with a pattern that makes it a bit easier to detect use-after-frees. calloc() returns zero-filled memory, so it can just call mmap() and return the result without triggering any page faults.

Does it make sense to allow such large values for -n? Wouldn't arg_max also work?

[jlduran_gmail.com]

usr.bin/xargs/xargs.c

261

Thank you for clarifying.
The only reason I presented this revision was to make te test pass. I also have a restricted testing environment, and the test you just disabled was crashing it.

[jlduran_gmail.com]

Test disabled in 2682a15527241278c9aa46c4907d3b07460b8ec0.

[markj]

One other possible solution would be something like this (untested):

-# This test may consume a large amount of memory, making it unsuited to CI
-# environments.  Disable it for now.
-#REGRESSION_TEST(`n2147483647', `xargs -n2147483647 <${SRCDIR}/regress.in')
+REGRESSION_TEST(`n2147483647', `MALLOC_CONF=junk:false xargs -n2147483647 <${SRCDIR}/regress.in')

That assumes that jemalloc is the malloc implementation in use, but I suspect it's harmless otherwise.