In some drivers we need to assert and deassert a group of hardware
resets in any order. To support this add a new hwreset_array that
manages all hwresets defined for a device.
Details
Details
- Reviewers
manu bz mmel - Group Reviewers
ARM arm64 - Commits
- rG5930ae92913b: Add support for an array of hwresets
rG969935b86b17: Add support for an array of hwresets
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 48294 Build 45180: arc lint + arc unit
Event Timeline
| sys/dev/extres/hwreset/hwreset_array.c | ||
|---|---|---|
| 120 | Wouldn't ENOMEM would be better ? | |
| sys/dev/extres/hwreset/hwreset_array.c | ||
|---|---|---|
| 120 | It should be removed. I thought mallocarray could return NULL on overflow, but it calls panic. | |
| sys/dev/extres/hwreset/hwreset_array.c | ||
|---|---|---|
| 120 | Ok, good for me then. | |
| sys/dev/extres/hwreset/hwreset_array.c | ||
|---|---|---|
| 129 | You don't need the { } and you could just for (; i >= 0; i--) probably? | |