HomeFreeBSD

Remove custom stderr formatting from net/rabbitmq.

Description

Remove custom stderr formatting from net/rabbitmq.

From upstream commit fecd0e5 in rabbitmq/rabbitmq-common:

Opening several ports for single fd is considered undefined behaviour
in erlang. It's safe to replace this whole function with 'io:format'.

Because writing to standard_error with io:format is synchronous - after
this call has returned data was definitely sent to the port. And
`erlang:halt` guarantees that this data will be flushed afterwards.

See also ba531a1 in erlang/otp:

Instead of outputting a formatted message showing errors found, a core
was (often) created.

This commit should fix all issues related to core dumps with RabbitMQ on
Erlang 18, which were most often observed when creating or joining
clusters.

MFH requested because a beam core dump would be most certainly interpreted
as the symptom of something worse within the Erlang VM.

PR: 204147
Submitted by: Alexey Lebedeff (follow up)
MFH: 2016Q1

Details

Provenance
olgeniAuthored on
Parents
rP409019: Update to the real version 4.4.1; r408807 was actually a beta.
Branches
Unknown
Tags
Unknown