HomeFreeBSD

Fixing gang ABD child removal race condition

Description

Fixing gang ABD child removal race condition

On linux the list debug code has been setting off a failure when
checking that the node->next->prev value is pointing back at the node.
At times this check evaluates to 0xdead. When removing a child from a
gang ABD we must acquire the child's abd_mtx to make sure that the
same ABD is not being added to another gang ABD while it is being
removed from a gang ABD. This fixes a race condition when checking
if an ABDs link is already active and part of another gang ABD before
adding it to a gang.

Added additional debug code for the gang ABD in abd_verify() to make
sure each child ABD has active links. Also check to make sure another
gang ABD is not added to a gang ABD.

Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes #10511

Details

Provenance
Brian Atkinson <batkinson@lanl.gov>Authored on Jul 14 2020, 6:04 PM
GitHub <noreply@github.com>Committed on Jul 14 2020, 6:04 PM
Parents
rGc15d36c674bc: Remove dependency on sharetab file and refactor sharing logic
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGe4d3d776844f: Fixing gang ABD child removal race condition (authored by Brian Atkinson <batkinson@lanl.gov>).Jul 14 2020, 6:04 PM