HomeFreeBSD

Better handling for future crypto parameters

Description

Better handling for future crypto parameters

The intent is that this is like ENOTSUP, but specifically for when
something can't be done because we have no support for the requested
crypto parameters; eg unlocking a dataset or receiving a stream
encrypted with a suite we don't support.

Its not intended to be recoverable without upgrading ZFS itself.
If the request could be made to work by enabling a feature or modifying
some other configuration item, then some other code should be used.

load-key: In the future we might have more crypto suites (ie new values
for the encryption property. Right now trying to load a key on such
a future crypto suite will look up suite parameters off the end of the
crypto table, resulting in misbehaviour and/or crashes (or, with debug
enabled, trip the assertion in zio_crypt_key_unwrap).

Instead, lets check the value we got from the dataset, and if we can't
handle it, abort early.

recv: When receiving a raw stream encrypted with an unknown crypto
suite, zfs recv would report a generic invalid backup stream
(EINVAL). While technically correct, its not super helpful, so lets
ship a more specific error code and message.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes #14577

Details

Provenance
rob.norris_klarasystems.comAuthored on Mar 7 2023, 10:05 PM
GitHub <noreply@github.com>Committed on Mar 7 2023, 10:05 PM
Parents
rG12a240ac0b3b: Fix a typo in ac2038a
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGb988f32c7017: Better handling for future crypto parameters (authored by Rob N <robn@despairlabs.com>).Mar 7 2023, 10:05 PM