HomeFreeBSD

Avoid deadlock when removing L2ARC devices under I/O

Description

Avoid deadlock when removing L2ARC devices under I/O

In case we have I/O and try to remove an L2ARC device a deadlock might
occur. arc_read()->zio_read()->zfs_blkptr_verify() waits for SCL_VDEV
to be dropped while holding the hash_lock. However, spa_l2cache_load()
holds SCL_ALL and waits for the hash_lock in l2arc_evict().

Fix this by moving zfs_blkptr_verify() to the top top arc_read() before
the hash_lock is taken. Verify the block pointer and return a checksum
error if damaged rather than halting the system, by using
BLK_VERIFY_LOG instead of BLK_VERIFY_HALT.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mark Maybee <mark.maybee@delphix.com>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes #12054

Details

Provenance
g_amanakis_yahoo.comAuthored on Jun 17 2021, 12:17 AM
GitHub <noreply@github.com>Committed on Jun 17 2021, 12:17 AM
Parents
rGff3175040572: Fix importing with symlinks
Branches
Unknown
Tags
Unknown