HomeFreeBSD

dnode_is_dirty: check dnode and its data for dirtiness

Description

dnode_is_dirty: check dnode and its data for dirtiness

Over its history this the dirty dnode test has been changed between
checking for a dnodes being on os_dirty_dnodes (dn_dirty_link) and
dn_dirty_record.

It turns out both are actually required.

In the case of appending data to a newly created file, the dnode proper
is dirtied (at least to change the blocksize) and dirty records are
added. Thus, a single logical operation is represented by separate
dirty indicators, and must not be separated.

The incorrect dirty check becomes a problem when the first block of a
file is being appended to while another process is calling lseek to skip
holes. There is a small window where the dnode part is undirtied while
there are still dirty records. In this case, lseek(fd, 0, SEEK_DATA)
would not know that the file is dirty, and would go to
dnode_next_offset(). Since the object has no data blocks yet, it
returns ESRCH, indicating no data found, which results in ENXIO
being returned to lseek()'s caller.

This change simply updates the dirty check to check both types of dirty.
If there's anything dirty at all, we immediately go to the "wait for
sync" stage, It doesn't really matter after that; both changes are on
disk, so the dirty fields should be correct.

Sponsored by: Klara, Inc.
Sponsored by: Wasabi Technology, Inc.
Approved by: so
Security: FreeBSD-EN-23:16.openzfs

(cherry picked from commit 8959056352256e79a63ba6327f0a0ee4236d3e7f)

Details

Provenance
rob.norris_klarasystems.comAuthored on Nov 30 2023, 5:14 AM
gordonCommitted on Nov 30 2023, 9:46 PM
Parents
rG69dcabf10d54: Add UPDATING entries and bump version.
Branches
Unknown
Tags
Unknown