HomeFreeBSD

Linux 6.6 compat: use inode_get/set_ctime*(...)

Description

Linux 6.6 compat: use inode_get/set_ctime*(...)

In Linux commit 13bc24457850583a2e7203ded05b7209ab4bc5ef, direct access
to the i_ctime member of struct inode was removed. The new approach is
to use accessor methods that exclusively handle passing the timestamp
around by value. This change adds new tests for each of these functions
and introduces zpl_* equivalents in include/os/linux/zfs/sys/zpl.h. In
where the inode_get/set_ctime*() functions exist, these zpl_* calls will
be mapped to the new functions. On older kernels, these macros just wrap
direct-access calls. The code that operated on an address of ip->i_ctime
to call ZFS_TIME_DECODE() now will take a local copy using
zpl_inode_get_ctime(), and then pass the address of the local copy when
performing the ZFS_TIME_DECODE() call, in all cases, rather than
directly accessing the member.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Coleman Kane <ckane@colemankane.org>
Closes #15263
Closes #15257
(cherry picked from commit fe9d409e90884a6b19572f4dfa1dd80cfc50d325)

Details

Provenance
Coleman Kane <ckane@colemankane.org>Authored on Sep 12 2023, 3:21 AM
Tony Hutter <hutter2@llnl.gov>Committed on Feb 8 2024, 9:29 PM
Parents
rGbb1dd98bccac: Workaround UBSAN errors for variable arrays
Branches
Unknown
Tags
Unknown

Event Timeline

Tony Hutter <hutter2@llnl.gov> committed rG73ab3bd088da: Linux 6.6 compat: use inode_get/set_ctime*(...) (authored by Coleman Kane <ckane@colemankane.org>).Feb 8 2024, 9:29 PM