HomeFreeBSD

Silence 'make checkbashisms'

Description

Silence 'make checkbashisms'

Commit d2bce6d03 added the 'make checkbashisms' target but did not
resolve all of the bashisms in the scripts. This commit doesn't
resolve them all either but it does fix up a few, and it excludes
the others so 'make checkstyle' no longer prints warnings. It's
a small step in the right direction.

  • Dracut is Linux specific and itself depends on bash. Therefore all dracut support scripts can be bash specific, update their shebang accordingly.
  • zed-functions.sh, zfs-import, zfs-mount, zfs-zed, smart paxcheck.sh, make_gitrev.sh - these scripts were excuded from the check until they can be updated and properly tested.
  • zfsunlock - only whole values for sleep are allowed.
  • vdev_id - removed unneeded locals; use && instead of -a.
  • dkms.mkconf, dkms.postbuil - use || instead of -o.

Reviewed-by: InsanePrawn <insane.prawny@gmail.com>
Reviewed-by: Gabriel A. Devenyi <gdevenyi@gmail.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #10755

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Aug 20 2020, 8:45 PM
GitHub <noreply@github.com>Committed on Aug 20 2020, 8:45 PM
Parents
rG7bba1d404cd2: 'zfs share -a' should clean noauto exports
Branches
Unknown
Tags
Unknown