HomeFreeBSD

contrib/bash_completion.d: fix error spew from __zfs_match_snapshot()

Description

contrib/bash_completion.d: fix error spew from __zfs_match_snapshot()

Given:

/sbin/zfs list filling/a-zvol<TAB> -o space,refratio

The rest of the cmdline gets vored by:

  /sbin/zfs list filling/a-zvolcannot open 'filling/a-zvol':
  operation not applicable to datasets of this type

With -x (fragment):

  + COMPREPLY=($(compgen -W "$(__zfs_match_snapshot)" -- "$cur"))
  +++ __zfs_match_snapshot
  +++ local base_dataset=filling/dziadtop-nowe-duchy
  +++ [[ filling/dziadtop-nowe-duchy != filling/dziadtop-nowe-duchy ]]
  +++ [[ filling/dziadtop-nowe-duchy != '' ]]
  +++ __zfs_list_datasets filling/dziadtop-nowe-duchy
  +++ /sbin/zfs list -H -o name -s name -t filesystem
                     -r filling/dziadtop-nowe-duchy
  +++ tail -n +2
  cannot open 'filling/dziadtop-nowe-duchy':
  operation not applicable to datasets of this type
  +++ echo filling/dziadtop-nowe-duchy
  +++ echo filling/dziadtop-nowe-duchy@
  ++ compgen -W 'filling/dziadtop-nowe-duchy

This properly completes with:

  $ /sbin/zfs list filling/a-zvol<TAB> -o space,refratio
  filling/a-zvol   filling/a-zvol@
  $ /sbin/zfs list filling/a-zvol<cursor> -o space,refratio

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12820

Details

Provenance
наб <nabijaczleweli@nabijaczleweli.xyz>Authored on Dec 7 2021, 8:30 PM
GitHub <noreply@github.com>Committed on Dec 7 2021, 8:30 PM
Parents
rGa78f19d3ec8e: Linux 5.16: Resolve ZSTD_isError symbol collision in Linux kernel
Branches
Unknown
Tags
Unknown