HomeFreeBSD

Simplify and document OpenZFS library dependencies

Description

Simplify and document OpenZFS library dependencies

For those not already familiar with the code base it can be a
challenge to understand how the libraries are laid out. This
has sometimes resulted in functionality being added in the
wrong place. To help avoid that in the future this commit
documents the high-level dependencies for easy reference in
lib/Makefile.am. It also simplifies a few things.

  • Switched libzpool dependency on libzfs_core to libzutil. This change makes it clear libzpool should never depend on the ioctl() functionality provided by libzfs_core.
  • Moved zfs_ioctl_fd() from libzutil to libzfs_core and renamed it lzc_ioctl_fd(). Normal access to the kmods should all be funneled through the libzfs_core library. The sole exception is the pool_active() which was updated to not use lzc_ioctl_fd() to remove the libzfs_core dependency.
  • Removed libzfs_core dependency on libzutil.
  • Removed the lib/libzfs/os/freebsd/libzfs_ioctl_compat.c source file which was all dead code.
  • Removed libzfs_core dependency from mkbusy and ctime test utilities. It was only needed for some trivial wrapper functions and that code is easy to replicate to shed the unneeded dependency.

Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #12602

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Oct 7 2021, 5:31 PM
GitHub <noreply@github.com>Committed on Oct 7 2021, 5:31 PM
Parents
rG48df24d4ce7b: Remove zdb and libzpool from initramfs image
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rG514498fef697: Simplify and document OpenZFS library dependencies (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Oct 7 2021, 5:31 PM