HomeFreeBSD

Always track temporary fses and snapshots for accounting

Description

Always track temporary fses and snapshots for accounting

The root cause of the issue is that we only occasionally do as the
comments in the code suggest and actually ignore the %recv dataset when
it comes to filesystem limit tracking. Specifically, the only time we
ignore it is when initializing the filesystem and snapshot limit values;
when creating a new %recv dataset or deleting one, we always update
the bookkeeping. This causes a problem if you init the fs count on a
filesystem that already has a %recv dataset, since the bookmarking
will be decremented but not incremented. This is resolved in this
patch by simply always tracking the %recv dataset as a child.

Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #10791

Details

Provenance
pcd_delphix.comAuthored on Aug 27 2020, 4:38 AM
GitHub <noreply@github.com>Committed on Aug 27 2020, 4:38 AM
Parents
rGad52de77c2a5: Fix broken bug report form
Branches
Unknown
Tags
Unknown