HomeFreeBSD

nowait synctask must succeed

Description

nowait synctask must succeed

If a zfs_space_check_t other than ZFS_SPACE_CHECK_NONE is used with
dsl_sync_task_nowait(), the sync task may fail due to ENOSPC.
However, there is no way to notice or communicate this failure, so it's
extremely difficult to use this functionality correctly, and in fact
almost all callers use ZFS_SPACE_CHECK_NONE.

This commit removes the zfs_space_check_t argument from
dsl_sync_task_nowait(), and always uses ZFS_SPACE_CHECK_NONE.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10855

Details

Provenance
mahrensAuthored on Sep 4 2020, 5:29 PM
GitHub <noreply@github.com>Committed on Sep 4 2020, 5:29 PM
Parents
rGcd8027390918: Retain thread name when resuming a zthr
Branches
Unknown
Tags
Unknown

Event Timeline