HomeFreeBSD

vdev_disk: don't touch vbio after its handed off to the kernel

Description

vdev_disk: don't touch vbio after its handed off to the kernel

After IO is unplugged, it may complete immediately and vbio_completion
be called on interrupt context. That may interrupt or deschedule our
task. If its the last bio, the vbio will be freed. Then, we get
rescheduled, and try to write to freed memory through vbio->.

This patch just removes the the cleanup, and the corresponding assert.
These were leftovers from a previous iteration of vbio_submit() and were
always "belt and suspenders" ops anyway, never strictly required.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc
Reported-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
(cherry picked from commit 917ff75e9510d19968ef3cc5c80b1cd0ef48f84d)

Details

Provenance
rob.norris_klarasystems.comAuthored on Apr 3 2024, 10:17 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Apr 8 2024, 5:13 PM
Parents
rGdeb7a84231af: Fix corruption caused by mmap flushing problems
Branches
Unknown
Tags
Unknown