HomeFreeBSD

Add config.rpath for AM_GNU_GETTEXT

Description

Add config.rpath for AM_GNU_GETTEXT

Commit e8864b1b28c2 ("config: libintl/libiconv for gettext() detection")
added an empty config.rpath with a comment that the real one doesn't
work with libtool.

However, an empty config.rpath doesn't really work: eg. on FreeBSD,
where libintl is in /usr/local/lib, configure thinks that gettext
doesn't exist and NLS should be disabled, which currently isn't
supported in the source, and hence requires manual workaround to
directly link -lintl without relying on configure. config.rpath is
essential to let it be detected either in --prefix or using
--with-libintl-prefix.

I also don't see the mentioned issue with libtool flags applied to
compilation, it seems to work fine to pass LTLIBINTL to libtool. It's
unnecessary to include LTLIBICONV as the configure test will
automatically append that to LTLIBINTL if it is necessary to link with
libiconv.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Closes #10538

Details

Provenance
Arvind Sankar <nivedita@alum.mit.edu>Authored on Jul 6 2020, 1:08 AM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jul 10 2020, 9:26 PM
Parents
rG4d61ade1a317: Clean up lib dependencies
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG1537105a8cfe: Add config.rpath for AM_GNU_GETTEXT (authored by Arvind Sankar <nivedita@alum.mit.edu>).Jul 10 2020, 9:26 PM