HomeFreeBSD

assertion in arc_release() during encrypted receive

Description

assertion in arc_release() during encrypted receive

In the existing code, when doing a raw (encrypted) zfs receive,
we call arc_convert_to_raw() from open context. This creates a
race condition between arc_release()/arc_change_state() and
writing out the block from syncing context (arc_write_ready/done()).

This change makes it so that when we are doing a raw (encrypted)
zfs receive, we save the crypt parameters (salt, iv, mac) of dnode
blocks in the dbuf_dirty_record_t, and call arc_convert_to_raw()
from syncing context when writing out the block of dnodes.

Additionally, we can eliminate dr_raw and associated setters, and
instead know that dnode blocks are always raw when doing a zfs
receive (see the new field os_raw_receive).

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tom Caputi <tcaputi@datto.com>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #7424
Closes #7429

Details

Provenance
mahrensAuthored on Apr 17 2018, 6:06 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Apr 17 2018, 6:06 PM
Parents
rGb40d45bc6c0e: ZTS: fix reservation_013_pos integer overflow
Branches
Unknown
Tags
Unknown