Page MenuHomeFreeBSD

vsrivard_netapp.com (Vivek Srivardhan)
User

Projects

User is not a member of any projects.

User Details

User Since
Mon, Oct 19, 6:53 PM (2 w, 3 d)

Recent Activity

Thu, Oct 29

vsrivard_netapp.com added a comment to D53386: bus: Take a step towards providing a proper topology lock.

We found another issue in testing with the sx held across device_detach(). device_sysctl_fini() in subr_bus.c sleeps in sysctl_ctx_free() (kern_sysctl.c) waiting for in-flight handlers to finish, but device_sysctl_handler() needs bus_topo_lock(). So if something is reading one of the device's sysctls (%iommu in our case) while it detaches, both sides get stuck. With just Giant this was fine, since it gets dropped across the sleep.

Thu, Oct 29, 8:30 PM

Tue, Oct 20

vsrivard_netapp.com added a comment to D53386: bus: Take a step towards providing a proper topology lock.

We pulled an earlier version of this (378b273) without the mi_startup() locking. The sx_assert caught a few Giant-only callers:

Tue, Oct 20, 8:46 PM