go.mk: Add -trimpath to GO_BUILDFLAGS
ClosedPublic
Actions

Authored by skozlov on May 17 2021, 9:52 PM.

Details

Reviewers

dmgk

Group Reviewers

portmgr

Commits

R11:475a23ad78aa: Mk/Uses/go.mk: Add -trimpath to GO_BUILDFLAGS

Summary

Available starting go 1.13.

From go 1.13 release notes:

The new go build flag -trimpath removes all file system paths from the
compiled executable, to improve build reproducibility.

Test Plan

Tested on www/pydio-cells, without fix grep -U 'skozlov' cells matches, with the fix - it doesn't.
Please advise what's the best way to test on the bigger number of ports.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 39261
Build 36150: arc lint + arc unit

Event Timeline

skozlov created this revision.May 17 2021, 9:52 PM

Herald added a reviewer: portmgr. · View Herald TranscriptMay 17 2021, 9:52 PM

Herald added a subscriber: mat. · View Herald Transcript

skozlov requested review of this revision.May 17 2021, 9:52 PM

Harbormaster completed remote builds in B39261: Diff 89377.May 17 2021, 9:52 PM

skozlov edited the test plan for this revision. (Show Details)May 17 2021, 10:25 PM

LGTM, thanks for the heads up. I was planning to add this, but somehow it slipped through cracks.
I'll do some more testing and will commit shortly.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2021, 4:02 PM

Closed by commit R11:475a23ad78aa: Mk/Uses/go.mk: Add -trimpath to GO_BUILDFLAGS (authored by skozlov, committed by dmgk). · Explain Why

This revision was automatically updated to reflect the committed changes.

dmgk added a commit: R11:475a23ad78aa: Mk/Uses/go.mk: Add -trimpath to GO_BUILDFLAGS.

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

go.mk

2 lines

Diff 89377

View Options

go.mk: Add -trimpath to GO_BUILDFLAGSClosedPublicActions