Page MenuHomeFreeBSD
Differential D30117

Fix PDO Bug in PHP 8
ClosedPublic
Actions

Authored by tz on May 5 2021, 8:40 AM.
Tags
None
Referenced Files
F150337638: D30117.id88666.diff
Tue, Mar 31, 7:52 AM
Unknown Object (File)
Sun, Mar 29, 4:15 PM
Unknown Object (File)
Tue, Mar 24, 7:44 PM
Unknown Object (File)
Tue, Mar 24, 4:26 PM
Unknown Object (File)
Tue, Mar 24, 3:31 PM
Unknown Object (File)
Tue, Mar 24, 3:31 PM
Unknown Object (File)
Tue, Mar 24, 12:27 AM
Unknown Object (File)
Mon, Mar 23, 10:25 PM
View All Files
Subscribers
None

Details

Reviewers
madpilot
Commits
R11:2bb8fefb3a2a: databases/php74-pdo_pgsql: Apply patch for PHP Bug 81002
R11:60f4fa9eedcf: databases/php80-pdo_pgsql: Apply patch for PHP Bug 81002
R11:8aea544d5b4c: databases/php74-pdo_pgsql: Apply patch for PHP Bug 81002
R11:31d2c89e2715: databases/php80-pdo_pgsql: Apply patch for PHP Bug 81002
Summary

There was a serious bug introduced in PHP 8.0.5: https://bugs.php.net/bug.php?id=80892

Except:
The test script below fails because the pgsql driver seems to treat everything as PARAM_STR, despite being explicitly requested to bind the value as PARAM_INT; the "?" placeholder is therefore replaced with the string '4326' instead of the integer 4326.

The problem is, in PostGIS, the ST_Transform() function has different signatures with different behaviours depending on whether the second parameter is an integer or a string.

As far as I can see, because of this issue, there is no way to pass an actual integer to a function without using explicit, PostgreSQL-specific CAST syntax.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 39026
Build 35915: arc lint + arc unit

Event Timeline

tz requested review of this revision.May 5 2021, 8:40 AM
tz created this revision.
madpilot updated this revision to Diff 88664.May 5 2021, 10:44 AM

Updating diff with patches for php 7.4.

I tested this on a server where I'm experiencing the issue.

Harbormaster completed remote builds in B39026: Diff 88664.May 5 2021, 10:44 AM
madpilot accepted this revision.May 5 2021, 10:45 AM

Took the freedom to update the patch with a fix for 7.4 too.

As reviewer I approve this.

This revision is now accepted and ready to land.May 5 2021, 10:45 AM
Closed by commit R11:31d2c89e2715: databases/php80-pdo_pgsql: Apply patch for PHP Bug 81002 (authored by tz). · Explain WhyMay 5 2021, 11:44 AM
This revision was automatically updated to reflect the committed changes.
tz added a commit: R11:31d2c89e2715: databases/php80-pdo_pgsql: Apply patch for PHP Bug 81002.
tz added a commit: R11:8aea544d5b4c: databases/php74-pdo_pgsql: Apply patch for PHP Bug 81002.
tz added a commit: R11:60f4fa9eedcf: databases/php80-pdo_pgsql: Apply patch for PHP Bug 81002.May 5 2021, 11:48 AM
tz added a commit: R11:2bb8fefb3a2a: databases/php74-pdo_pgsql: Apply patch for PHP Bug 81002.

Revision Contents
Changeset List

PathSize
databases/
php74-pdo_pgsql/
2 lines
files/
42 lines
80 lines
php80-pdo_pgsql/
2 lines
files/
42 lines
80 lines

Diff 88664

View Options

databases/php74-pdo_pgsql/Makefile

Loading...
View Options

databases/php74-pdo_pgsql/files/patch-pgsql__statement.c

Loading...
View Options

databases/php74-pdo_pgsql/files/patch-tests_bug__80892.phpt

Loading...
View Options

databases/php80-pdo_pgsql/Makefile

Loading...
View Options

databases/php80-pdo_pgsql/files/patch-pgsql__statement.c

Loading...
View Options

databases/php80-pdo_pgsql/files/patch-tests_bug__80892.phpt

Loading...