Page MenuHomeFreeBSD
Differential D27894

Unused variables after WARNS=6 in bootparamd.c
ClosedPublic
Actions

Authored by otis on Jan 2 2021, 2:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 27, 1:54 PM
Unknown Object (File)
Wed, Jul 23, 4:04 AM
Unknown Object (File)
Mon, Jul 7, 9:12 AM
Unknown Object (File)
Fri, Jul 4, 7:32 PM
Unknown Object (File)
Tue, Jul 1, 3:25 PM
Unknown Object (File)
Jun 18 2025, 3:00 PM
Unknown Object (File)
Jun 17 2025, 1:48 AM
Unknown Object (File)
Jun 16 2025, 9:54 PM
View All 77 Files
Subscribers
None

Details

Reviewers
nyan
Commits
rG580311ef3283: bootparamd: Add missing __unused mark.
rG8c45fe5d8ecd: bootparamd: Add missing __unused mark.
Summary

Commit e03764d931d820185a019334259b18df2e3f6b6c did not catch all unused variables. Mark them accordingly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

otis requested review of this revision.Jan 2 2021, 2:46 PM
otis created this revision.

The other way around would be to get rid of the len and blen as they seem to be not used as of now.

nyan accepted this revision.Jan 2 2021, 3:38 PM

I overlooked MK_NIS=no case. I'll commit this patch.
Thank you for your report.

This revision is now accepted and ready to land.Jan 2 2021, 3:38 PM
Closed by commit rG8c45fe5d8ecd: bootparamd: Add missing __unused mark. (authored by nyan). · Explain WhyJan 2 2021, 3:51 PM
This revision was automatically updated to reflect the committed changes.
nyan added a commit: rG8c45fe5d8ecd: bootparamd: Add missing __unused mark..
nyan added a commit: rG580311ef3283: bootparamd: Add missing __unused mark..Jan 19 2021, 2:58 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bootparamd/
bootparamd/
4 lines

Diff 81507

View Options

usr.sbin/bootparamd/bootparamd/bootparamd.c

Show First 20 Lines • Show All 173 Lines • ▼ Show 20 Lines
/* getthefile return 1 and fills the buf with the information /* getthefile return 1 and fills the buf with the information
of the file, e g "host:/export/root/client" if it can be found. of the file, e g "host:/export/root/client" if it can be found.
If the host is in the database, but the file is not, the buf If the host is in the database, but the file is not, the buf
will be empty. (This makes it possible to give the special will be empty. (This makes it possible to give the special
empty answer for the file "dump") */ empty answer for the file "dump") */
static int static int
getthefile(char *l_askname, char *fileid, char *buf, int blen) getthefile(char *l_askname, char *fileid, char *buf, int blen __unused)
{ {
FILE *bpf; FILE *bpf;
char *where; char *where;
#ifdef YP #ifdef YP
static char *result; static char *result;
int resultlen; int resultlen;
static char *yp_domain; static char *yp_domain;
#endif #endif
▲ Show 20 Lines • Show All 89 Lines • ▼ Show 20 Lines#define REXPAND(d) AS_FORMAT(d) /* Force another preprocessor expansion */
return(match); return(match);
} }
/* checkhost puts the hostname found in the database file in /* checkhost puts the hostname found in the database file in
the l_hostname-variable and returns 1, if l_askname is a valid the l_hostname-variable and returns 1, if l_askname is a valid
name for a host in the database */ name for a host in the database */
static int static int
checkhost(char *l_askname, char *l_hostname, int len) checkhost(char *l_askname, char *l_hostname, int len __unused)
{ {
int ch, pch; int ch, pch;
FILE *bpf; FILE *bpf;
int res = 0; int res = 0;
#ifdef YP #ifdef YP
static char *result; static char *result;
int resultlen; int resultlen;
static char *yp_domain; static char *yp_domain;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines