Page MenuHomeFreeBSD
Differential D3090

Update p4api to 2015.1/1054991
ClosedPublic
Actions

Authored by gordon on Jul 15 2015, 5:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 2:56 PM
Unknown Object (File)
Wed, Dec 4, 2:35 AM
Unknown Object (File)
Sun, Dec 1, 3:29 PM
Unknown Object (File)
Sat, Nov 30, 12:29 AM
Unknown Object (File)
Tue, Nov 26, 9:50 PM
Unknown Object (File)
Oct 18 2024, 12:38 PM
Unknown Object (File)
Oct 18 2024, 6:18 AM
Unknown Object (File)
Oct 12 2024, 12:32 AM
View All Files
Subscribers
None

Details

Reviewers
erwin
mat
Commits
rP392752: MFH: r392751
rP392751: Unbreak devel/p4api and update to 2015.1/1126382

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

gordon updated this revision to Diff 6953.Jul 15 2015, 5:20 AM
gordon retitled this revision from to Update p4api to 2015.1/1054991.
gordon updated this object.
gordon edited the test plan for this revision. (Show Details)
gordon added reviewers: mat, erwin.
mat accepted this revision.Jul 15 2015, 3:07 PM
mat edited edge metadata.
This revision is now accepted and ready to land.Jul 15 2015, 3:07 PM
gordon updated this revision to Diff 6994.Jul 16 2015, 4:11 AM
gordon edited edge metadata.

Remove common variables migrated to p4/Makefile.inc

This revision now requires review to proceed.Jul 16 2015, 4:11 AM
mat added inline comments.Jul 16 2015, 6:58 AM
devel/p4api/Makefile
17–18

This is the default value, it can be removed.

30–31

This should be written as:

cd ${${WRKSRC}/include/p4 && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/include/perforce

If there are files other than .h files, possibly adding "-name '*.h'" as a third argument.

30–31

same for this.

34–35

and for this.

gordon updated this revision to Diff 7068.Jul 19 2015, 12:05 AM
gordon marked 3 inline comments as done.
gordon edited edge metadata.

Update to use COPYTREE_SHARE for install (nifty command)
Remove uneeded WRKSRC reference.

gordon marked an inline comment as done.Jul 19 2015, 12:06 AM
mat accepted this revision.Jul 19 2015, 8:21 AM
mat edited edge metadata.
This revision is now accepted and ready to land.Jul 19 2015, 8:21 AM
gordon updated this revision to Diff 7237.Jul 23 2015, 8:13 PM
gordon edited edge metadata.

Update to latest version.

This revision now requires review to proceed.Jul 23 2015, 8:13 PM
Closed by commit rP392751: Unbreak devel/p4api and update to 2015.1/1126382 (authored by gordon). · Explain WhyJul 23 2015, 8:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7068

View Options

devel/p4api/Makefile

Loading...
View Options

devel/p4api/distinfo.freebsd100x86

Loading...
View Options

devel/p4api/distinfo.freebsd100x86_64

Loading...
View Options

devel/p4api/distinfo.freebsd70x86

Loading...
View Options

devel/p4api/distinfo.freebsd70x86_64

Loading...
View Options

devel/p4api/pkg-plist

Loading...