Page MenuHomeFreeBSD
Differential D22166

www/qt5-webengine: Add back required patches for armv7
ClosedPublic
Actions

Authored by kai on Oct 27 2019, 10:39 AM.
Tags
None
Referenced Files
F151168055: D22166.id63713.diff
Mon, Apr 6, 1:35 PM
Unknown Object (File)
Mon, Apr 6, 1:35 AM
Unknown Object (File)
Sun, Apr 5, 9:25 AM
Unknown Object (File)
Sat, Apr 4, 5:21 AM
Unknown Object (File)
Tue, Mar 31, 10:52 PM
Unknown Object (File)
Thu, Mar 26, 7:54 AM
Unknown Object (File)
Mar 5 2026, 1:00 AM
Unknown Object (File)
Mar 3 2026, 10:53 AM
View All Files
Subscribers
tcberner

Details

Reviewers
tcberner
Group Reviewers
kde
Commits
rP515850: www/qt5-webengine: Restore patches required for armv7
Summary
  • Copy patch-src_3rdparty_chromium_v8_src_base_platform_platform-freebsd.cc and patch-src_3rdparty_chromium_v8_src_libsampler_sampler.cc back from rP515730 (= revision prior the update to 5.13.0). Both files were introduced in rP497877 and should have been left untouched with rP515731.
  • Not bumping PORTREVISION because only armv7 related code has changed and it's not yet known if the port can be built successfully on that architecture.
Test Plan
  • poudriere 11.3-RELEASE amd64 -> OK

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27235
Build 25499: arc lint + arc unit

Event Timeline

kai created this revision.Oct 27 2019, 10:39 AM
Harbormaster completed remote builds in B27235: Diff 63712.Oct 27 2019, 10:39 AM
kai updated this revision to Diff 63713.Oct 27 2019, 10:51 AM

Add both files via svn add to see the contents for a better review. I'll svn copy both files once the review gets approved.

Harbormaster completed remote builds in B27236: Diff 63713.Oct 27 2019, 10:51 AM
kai edited the summary of this revision. (Show Details)Oct 27 2019, 10:55 AM
tcberner accepted this revision.Oct 28 2019, 7:23 AM
tcberner added a subscriber: tcberner.

Looks good to me.

This revision is now accepted and ready to land.Oct 28 2019, 7:23 AM
Closed by commit rP515850: www/qt5-webengine: Restore patches required for armv7 (authored by kai). · Explain WhyOct 28 2019, 9:25 AM
This revision was automatically updated to reflect the committed changes.
kai added a commit: rP515850: www/qt5-webengine: Restore patches required for armv7.

Revision Contents
Changeset List

Diff 63712

View Options

www/qt5-webengine/files/patch-src_3rdparty_chromium_v8_src_base_platform_platform-freebsd.cc

Loading...
View Options

www/qt5-webengine/files/patch-src_3rdparty_chromium_v8_src_libsampler_sampler.cc

Loading...