Page MenuHomeFreeBSD
Differential D20159

New port: editors/xi-term: Terminal frontend for xi-editor
ClosedPublic
Actions

Authored by kai on May 4 2019, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 3:11 AM
Unknown Object (File)
Nov 23 2024, 5:48 AM
Unknown Object (File)
Nov 22 2024, 10:29 AM
Unknown Object (File)
Nov 21 2024, 2:05 AM
Unknown Object (File)
Nov 9 2024, 8:24 AM
Unknown Object (File)
Oct 25 2024, 11:20 PM
Unknown Object (File)
Oct 25 2024, 11:20 PM
Unknown Object (File)
Oct 25 2024, 11:19 PM
View All 65 Files
Subscribers
tobik

Details

Reviewers
tobik
Group Reviewers
rust
Commits
rP500856: New port: editors/xi-term
Summary

Formely xi-tui, xi-term is a terminal frontend for xi.

It is experimental and under development, so don't expect
anything magical (yet!).

WWW: https://github.com/xi-frontend/xi-term

PR: 237533
Submitted by: Nuno Teixeira

Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r346346 amd64 + i386) -> OK
  • portlint -> OK
  • Runtime tests -> OK

Minor fixes from the original patch:

  • Removed OPTIONS_DEFAULT=DOCS as DOCS is already set as default
  • Rearranged GH_TUPLE and CARGO_USE_GITHUB to make future update/commits somewhat easier

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24106
Build 22967: arc lint + arc unit

Event Timeline

kai created this revision.May 4 2019, 9:49 PM
Harbormaster completed remote builds in B24106: Diff 57050.May 4 2019, 9:49 PM
tobik requested changes to this revision.May 4 2019, 10:29 PM
tobik added a subscriber: tobik.

Same nitpicks as in D20158:

  • CARGO_USE_GITHUB in the wrong order
  • INSTALL_MAN for installing documentation
editors/xi-term/pkg-descr
1–4

This is not a good pkg-descr. Maybe explain what xi is in a one or two sentences (or copy some sentences from xi-core's description).

This revision now requires changes to proceed.May 4 2019, 10:29 PM
kai updated this revision to Diff 57056.May 4 2019, 10:51 PM
  • Rearranged GH_TUPLE, CARGO_CRATES, CARGO_USE_GITHUB
  • s/${INSTALL_DATA}/${INSTALL_MAN}/
  • Improved pkg-descr by copying some lines from pkg-descr of www/xi-core
Harbormaster completed remote builds in B24110: Diff 57056.May 4 2019, 10:51 PM
tobik accepted this revision.May 4 2019, 10:56 PM
This revision is now accepted and ready to land.May 4 2019, 10:56 PM
kai planned changes to this revision.May 4 2019, 11:01 PM

Awesome, many thanks also here for your suggestions and the quick review!

This revision was not accepted when it landed; it landed in state Changes Planned.May 5 2019, 1:16 PM
Closed by commit rP500856: New port: editors/xi-term (authored by kai). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
editors/
1 line
177 lines
287 lines
6 lines

Diff 57050

View Options

editors/Makefile

Loading...
View Options

editors/xi-term/

Loading...
View Options

editors/xi-term/Makefile

Loading...
View Options

editors/xi-term/distinfo

Loading...
View Options

editors/xi-term/pkg-descr

Loading...