Page MenuHomeFreeBSD

Avoid completing non-dump I/O requests after a panic.
AbandonedPublic

Authored by markj on May 27 2018, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 26, 4:28 PM
Unknown Object (File)
Mon, Aug 24, 4:12 AM
Unknown Object (File)
Sat, Aug 22, 1:55 PM
Unknown Object (File)
Fri, Aug 21, 3:03 PM
Unknown Object (File)
Thu, Aug 20, 6:54 PM
Unknown Object (File)
Thu, Aug 20, 1:14 AM
Unknown Object (File)
Tue, Aug 18, 2:49 PM
Unknown Object (File)
Tue, Aug 18, 2:46 PM
Subscribers
None

Details

Reviewers
None
Summary

Currently we might call into filesystem or pager code when completing a
non-dump CCB, which typically results in assertion failures or
deadlocks when dumping. D4647 attempted to handle this with a dedicated
CAM doneq, but as was pointed out in the review, that solution may cause
us to fail to unfreeze the device after an error. Try to handle the
problem a different way: filter non-dump CCBs in xpt_done_process(), and
attempt to unfreeze the devq after an error if we're running after a
panic. Stash non-dump CCBs on a list so that they can be inspected
during a debugging session.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16870
Build 16747: arc lint + arc unit